RESOLVED FIXED 31126
bugzilla-tool's reviewer/committer rejection message should be clearer
https://bugs.webkit.org/show_bug.cgi?id=31126
Summary bugzilla-tool's reviewer/committer rejection message should be clearer
Eric Seidel (no email)
Reported 2009-11-04 09:53:14 PST
bugzilla-tool's reviewer/committer rejection message should be clearer The message should give action steps like. 1. If you believe this message is in error, please add yourself as a Committer or Reviewer to committers.py and reset the flag. 2. If you are not a committer/reviewer please set review=? or commit-queue=? instead and a reviewer/committer will set review+ commit-queue+ for you. The prose should be briefer than that, and should include a link to the contributing docs.
Attachments
Patch (2.64 KB, patch)
2009-11-17 16:38 PST, Eric Seidel (no email)
no flags
Add some extra newlines in the message to make it more readable (2.73 KB, patch)
2009-11-17 16:47 PST, Eric Seidel (no email)
darin: review+
eric: commit-queue-
Eric Seidel (no email)
Comment 1 2009-11-17 16:38:53 PST
Eric Seidel (no email)
Comment 2 2009-11-17 16:40:21 PST
As an example, I'll ask someone without review access to r+ this patch.
WebKit Commit Bot
Comment 3 2009-11-17 16:44:39 PST
Comment on attachment 43389 [details] Patch Rejecting patch 43389 from review queue. evan@chromium.org does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/modules/committers.py. If you have reviewer rights please correct the error in WebKitTools/Scripts/modules/committers.py by adding yourself to the file (no review needed) and then set the reviewer flag again. If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.
Eric Seidel (no email)
Comment 4 2009-11-17 16:47:26 PST
Created attachment 43391 [details] Add some extra newlines in the message to make it more readable
Eric Seidel (no email)
Comment 5 2009-11-17 17:08:21 PST
Comment on attachment 43391 [details] Add some extra newlines in the message to make it more readable Evan was just trying to be helpful. :) But I'd like a real review on this one.
Dmitry Titov
Comment 6 2009-11-17 23:53:43 PST
Comment on attachment 43391 [details] Add some extra newlines in the message to make it more readable > diff --git a/WebKitTools/Scripts/modules/bugzilla.py b/WebKitTools/Scripts/modules/bugzilla.py > + if True: > + rejection_function(patch['id'], self._flag_permission_rejection_message(setter_email, result_key)) > else: Is this supposed to be "if True"? When the subsequent "else:" will be taken?
Darin Adler
Comment 7 2009-11-18 10:57:48 PST
Comment on attachment 43391 [details] Add some extra newlines in the message to make it more readable rs=me
Eric Seidel (no email)
Comment 8 2009-11-18 15:21:03 PST
Comment on attachment 43391 [details] Add some extra newlines in the message to make it more readable This needs to be landed by hand due to my error in this diff.
Eric Seidel (no email)
Comment 9 2009-11-19 12:28:17 PST
Note You need to log in before you can comment on or make changes to this bug.