bugzilla-tool's reviewer/committer rejection message should be clearer The message should give action steps like. 1. If you believe this message is in error, please add yourself as a Committer or Reviewer to committers.py and reset the flag. 2. If you are not a committer/reviewer please set review=? or commit-queue=? instead and a reviewer/committer will set review+ commit-queue+ for you. The prose should be briefer than that, and should include a link to the contributing docs.
Created attachment 43389 [details] Patch
As an example, I'll ask someone without review access to r+ this patch.
Comment on attachment 43389 [details] Patch Rejecting patch 43389 from review queue. evan@chromium.org does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/modules/committers.py. If you have reviewer rights please correct the error in WebKitTools/Scripts/modules/committers.py by adding yourself to the file (no review needed) and then set the reviewer flag again. If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.
Created attachment 43391 [details] Add some extra newlines in the message to make it more readable
Comment on attachment 43391 [details] Add some extra newlines in the message to make it more readable Evan was just trying to be helpful. :) But I'd like a real review on this one.
Comment on attachment 43391 [details] Add some extra newlines in the message to make it more readable > diff --git a/WebKitTools/Scripts/modules/bugzilla.py b/WebKitTools/Scripts/modules/bugzilla.py > + if True: > + rejection_function(patch['id'], self._flag_permission_rejection_message(setter_email, result_key)) > else: Is this supposed to be "if True"? When the subsequent "else:" will be taken?
Comment on attachment 43391 [details] Add some extra newlines in the message to make it more readable rs=me
Comment on attachment 43391 [details] Add some extra newlines in the message to make it more readable This needs to be landed by hand due to my error in this diff.
Committed r51202: <http://trac.webkit.org/changeset/51202>