Bug 31125 – REGRESSION (r47121): bugzilla-tool create-bug raises exception after entering bug description

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Adam Roben (:aroben)]

Created attachment 42490 [details]
Patch

It looks like this:

 % bugzilla-tool create-bug --cc [e-mail],[e-mail] HEAD
Bug title: Tell the WebFrameLoadDelegate when window objects in isolated worlds are cleared
Bug comment (hit ^D on blank line to end):
We should tell the WebFrameLoadDelegate when window objects in isolated worlds are cleared so that they can modify the objects as needed.
Traceback (most recent call last):
  File "/Users/aroben/dev/WebKit/OpenSource/WebKitTools/Scripts/bugzilla-tool", line 917, in <module>
    main()
  File "/Users/aroben/dev/WebKit/OpenSource/WebKitTools/Scripts/bugzilla-tool", line 914, in main
    return tool.main()
  File "/Users/aroben/dev/WebKit/OpenSource/WebKitTools/Scripts/bugzilla-tool", line 909, in main
    return command_object.execute(command_options, command_args, self)
  File "/Users/aroben/dev/WebKit/OpenSource/WebKitTools/Scripts/bugzilla-tool", line 636, in execute
    self.create_bug_from_commit(options, args, tool)
  File "/Users/aroben/dev/WebKit/OpenSource/WebKitTools/Scripts/bugzilla-tool", line 583, in create_bug_from_commit
    (bug_title, comment_text) = self.prompt_for_bug_title_and_comment()
  File "/Users/aroben/dev/WebKit/OpenSource/WebKitTools/Scripts/bugzilla-tool", line 628, in prompt_for_bug_title_and_comment
    raise
TypeError: exceptions must be classes or instances, not NoneType

[Eric Seidel (no email)]

I wonder if this is a dupe of either bug 30537 or bug 28251.

[David Kilzer (:ddkilzer)]

Comment on attachment 42490 [details]
Patch

r=me

[Eric Seidel (no email)]

Comment on attachment 42490 [details]
Patch

ChangeLog looks wrong, but otherwise looks fine.  Does create-bug know how to fix a ChangeLog (since I assume you created this with create-bug)?

[Adam Roben (:aroben)]

(In reply to comment #3)
> (From update of attachment 42490 [details])
> ChangeLog looks wrong

Do you mean because it says "OOPS!"? Or is there something else wrong about it?

> Does create-bug know how to fix a ChangeLog

create-bug doesn't touch ChangeLogs.

> (since I assume you created this with create-bug)?

I did.

[Eric Seidel (no email)]

Yes, the only thing "Wrong" with the ChangeLog is the missing bug link, etc.  which prepare-changeLog --bug 31125 would know how to provide for you, and create-bug should be taught how to fill in for you too. :)

[Adam Roben (:aroben)]

*** Bug 28251 has been marked as a duplicate of this bug. ***

[Adam Roben (:aroben)]

Committed r50565: <http://trac.webkit.org/changeset/50565>