Bug 31121 - WebInspector: Prevent crash when InspectorTimelineAgent is enabled/disabled: follow on to bug 31080
: WebInspector: Prevent crash when InspectorTimelineAgent is enabled/disabled: ...
Status: RESOLVED FIXED
: WebKit
Web Inspector (Deprecated)
: 528+ (Nightly build)
: All All
: P2 Normal
Assigned To:
:
:
:
:
  Show dependency treegraph
 
Reported: 2009-11-04 08:02 PST by
Modified: 2009-11-04 12:04 PST (History)


Attachments
WebInspector: Handle turning timeline profiling on/off in the middle of event dispatch (7.50 KB, patch)
2009-11-04 09:02 PST, Eric Ayers
timothy: review-
Review Patch | Details | Formatted Diff | Diff
WebInspector: Handle turning timeline profiling on/off in the middle of event dispatch (9.15 KB, patch)
2009-11-04 10:52 PST, Eric Ayers
no flags Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2009-11-04 08:02:32 PST
This patch completes the work started by bug 31080 to not save the timelineAgent pointer between beginning and ending an entry point.
------- Comment #1 From 2009-11-04 09:02:30 PST -------
Created an attachment (id=42488) [details]
WebInspector: Handle turning timeline profiling on/off in the middle of event dispatch
------- Comment #2 From 2009-11-04 09:12:33 PST -------
(From update of attachment 42488 [details])
DOMWindow.cpp has somewhat large copypaste. Please consider extracting method in one of your next patches.
------- Comment #3 From 2009-11-04 09:25:35 PST -------
(From update of attachment 42488 [details])
Rejecting patch 42488 from commit-queue.

Failed to run "['git', 'svn', 'dcommit']" exit_code: 1
Last 500 characters of output:
page/FrameView.cpp
    M    WebCore/xml/XMLHttpRequest.cpp
A repository hook failed: MERGE request failed on '/repository/webkit/trunk': Commit blocked by pre-commit hook (exit code 1) with output:
svnlook: Can't write to stream: Broken pipe

    The following files contain tab characters:

        trunk/WebCore/ChangeLog

    Please use spaces instead to indent.
    If you must commit a file with tabs, use svn propset to set the "allow-tabs" property.
 at /usr/local/libexec/git-core//git-svn line 469
------- Comment #4 From 2009-11-04 09:29:10 PST -------
We need to make some tool which knows how to warn contributors earlier than a pre-commit hook.  :(
------- Comment #5 From 2009-11-04 09:34:37 PST -------
(In reply to comment #4)
> We need to make some tool which knows how to warn contributors earlier than a
> pre-commit hook.  :(

svn-create-patch? (Wont help the git users or direct users on svn diff.)
------- Comment #6 From 2009-11-04 09:36:36 PST -------
(From update of attachment 42488 [details])

>  #if ENABLE(INSPECTOR)
> +      timelineAgent = InspectorTimelineAgent::retrieve(scriptExecutionContext());
>          bool callTimelineAgentOnLoad = timelineAgent && hasEventListeners(eventNames().loadEvent);

Bad indentation here.

Also remore the tabs from the ChangeLog.
------- Comment #7 From 2009-11-04 10:52:41 PST -------
Created an attachment (id=42494) [details]
WebInspector: Handle turning timeline profiling on/off in the middle of event dispatch

Gets rid of tabs in Changelog, 
Fixes formatting in XMLHttpRequest.cpp
Extracts some logic to a private method in DOMWindow.cpp
------- Comment #8 From 2009-11-04 12:04:26 PST -------
(From update of attachment 42494 [details])
Clearing flags on attachment: 42494

Committed r50523: <http://trac.webkit.org/changeset/50523>
------- Comment #9 From 2009-11-04 12:04:31 PST -------
All reviewed patches have been landed.  Closing bug.