This patch completes the work started by bug 31080 to not save the timelineAgent pointer between beginning and ending an entry point.
Created attachment 42488 [details] WebInspector: Handle turning timeline profiling on/off in the middle of event dispatch
Comment on attachment 42488 [details] WebInspector: Handle turning timeline profiling on/off in the middle of event dispatch DOMWindow.cpp has somewhat large copypaste. Please consider extracting method in one of your next patches.
Comment on attachment 42488 [details] WebInspector: Handle turning timeline profiling on/off in the middle of event dispatch Rejecting patch 42488 from commit-queue. Failed to run "['git', 'svn', 'dcommit']" exit_code: 1 Last 500 characters of output: page/FrameView.cpp M WebCore/xml/XMLHttpRequest.cpp A repository hook failed: MERGE request failed on '/repository/webkit/trunk': Commit blocked by pre-commit hook (exit code 1) with output: svnlook: Can't write to stream: Broken pipe The following files contain tab characters: trunk/WebCore/ChangeLog Please use spaces instead to indent. If you must commit a file with tabs, use svn propset to set the "allow-tabs" property. at /usr/local/libexec/git-core//git-svn line 469
We need to make some tool which knows how to warn contributors earlier than a pre-commit hook. :(
(In reply to comment #4) > We need to make some tool which knows how to warn contributors earlier than a > pre-commit hook. :( svn-create-patch? (Wont help the git users or direct users on svn diff.)
Comment on attachment 42488 [details] WebInspector: Handle turning timeline profiling on/off in the middle of event dispatch > #if ENABLE(INSPECTOR) > + timelineAgent = InspectorTimelineAgent::retrieve(scriptExecutionContext()); > bool callTimelineAgentOnLoad = timelineAgent && hasEventListeners(eventNames().loadEvent); Bad indentation here. Also remore the tabs from the ChangeLog.
Created attachment 42494 [details] WebInspector: Handle turning timeline profiling on/off in the middle of event dispatch Gets rid of tabs in Changelog, Fixes formatting in XMLHttpRequest.cpp Extracts some logic to a private method in DOMWindow.cpp
Comment on attachment 42494 [details] WebInspector: Handle turning timeline profiling on/off in the middle of event dispatch Clearing flags on attachment: 42494 Committed r50523: <http://trac.webkit.org/changeset/50523>
All reviewed patches have been landed. Closing bug.