Bug 311123 – [Site Isolation] Web Inspector: Layout tests with cross-origin iframes crash due to assertion failure: !globalObject->debugger()

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Qianlang Chen]

On a debug build, run
    run-webkit-tests --debug --no-build --no-retry-failures --no-show-results --full-diff-context --child-processes=1 --timeout=25000 --force --exit-after-n-failures=1 LayoutTests/http/tests/site-isolation/inspector/debugger/pause-in-cross-origin-iframe.html

Or theoretically most other Web Inspector test for site isolation, resulting in the following crash log:
ASSERTION FAILED: !globalObject->debugger()
/Users/qianlang_chen1/WebKit/OpenSource/Source/JavaScriptCore/debugger/Debugger.cpp(168) : void JSC::Debugger::attach(JSGlobalObject *)
1   0x131dc24ec JSC::Debugger::attach(JSC::JSGlobalObject*)
2   0x7000128f50 WebCore::JSWindowProxy::attachDebugger(JSC::Debugger*)
3   0x7005043698 WebCore::WindowProxy::attachDebugger(JSC::Debugger*)
4   0x70072a4480 WebCore::Page::setDebugger(JSC::Debugger*)
5   0x70069e2d08 WebCore::PageDebugger::attachDebugger()
6   0x131dc3410 JSC::Debugger::addObserver(JSC::Debugger::Observer&)
7   0x1326911cc Inspector::InspectorDebuggerAgent::internalEnable()
8   0x7006b236ac WebCore::WebDebuggerAgent::internalEnable()
9   0x7006b6ae8c WebCore::PageDebuggerAgent::internalEnable()
10  0x132691c6c Inspector::InspectorDebuggerAgent::enable()
11  0x13259876c Inspector::DebuggerBackendDispatcher::enable(long, WTF::RefPtr<WTF::JSONImpl::Object, WTF::RawPtrTraits<WTF::JSONImpl::Object>, WTF::DefaultRefDerefTraits<WTF::JSONImpl::Object>>&&)
12  0x132598654 Inspector::DebuggerBackendDispatcher::dispatch(long, WTF::String const&, WTF::Ref<WTF::JSONImpl::Object, WTF::RawPtrTraits<WTF::JSONImpl::Object>, WTF::DefaultRefDerefTraits<WTF::JSONImpl::Object>>&&)
13  0x132572c38 Inspector::BackendDispatcher::dispatch(WTF::String const&)
14  0x70069e63e4 WebCore::PageInspectorController::dispatchMessageFromFrontend(WTF::String const&)
15  0x11e105028 WebKit::PageInspectorTarget::sendMessageToTargetBackend(WTF::String const&)
16  0x11e5dff44 WebKit::WebPage::sendMessageToTargetBackend(WTF::String const&)
17  0x11bb83028 auto void IPC::callMemberFunction<WebKit::WebPage, WebKit::WebPage, void (WTF::String const&), std::__1::tuple<WTF::String>>(WebKit::WebPage*, void (WebKit::WebPage::*)(WTF::String const&), std::__1::tuple<WTF::String>&&)::'lambda'(auto&&...)::operator()<WTF::String>(auto&&...) const
18  0x11bb82f60 std::__1::__invoke_result_impl<void, auto...>::type std::__1::__invoke[abi:sqn220100]<void IPC::callMemberFunction<WebKit::WebPage, WebKit::WebPage, void (WTF::String const&), std::__1::tuple<WTF::String>>(WebKit::WebPage*, void (WebKit::WebPage::*)(WTF::String const&), std::__1::tuple<WTF::String>&&)::'lambda'(auto&&...), WTF::String>(auto&&...)
19  0x11bb82f30 decltype(auto) std::__1::__apply_tuple_impl[abi:sqn220100]<void IPC::callMemberFunction<WebKit::WebPage, WebKit::WebPage, void (WTF::String const&), std::__1::tuple<WTF::String>>(WebKit::WebPage*, void (WebKit::WebPage::*)(WTF::String const&), std::__1::tuple<WTF::String>&&)::'lambda'(auto&&...), std::__1::tuple<WTF::String>, 0ul>(WebKit::WebPage&&, WebKit::WebPage&&, std::__1::integer_sequence<unsigned long, 0ul>)
20  0x11bb82ef0 decltype(auto) std::__1::apply[abi:sqn220100]<void IPC::callMemberFunction<WebKit::WebPage, WebKit::WebPage, void (WTF::String const&), std::__1::tuple<WTF::String>>(WebKit::WebPage*, void (WebKit::WebPage::*)(WTF::String const&), std::__1::tuple<WTF::String>&&)::'lambda'(auto&&...), std::__1::tuple<WTF::String>>(WebKit::WebPage&&, WebKit::WebPage&&)
21  0x11bb82ec0 void IPC::callMemberFunction<WebKit::WebPage, WebKit::WebPage, void (WTF::String const&), std::__1::tuple<WTF::String>>(WebKit::WebPage*, void (WebKit::WebPage::*)(WTF::String const&), std::__1::tuple<WTF::String>&&)
22  0x11ba9e108 void IPC::handleMessage<Messages::WebPage::SendMessageToTargetBackend, IPC::Connection, WebKit::WebPage, WebKit::WebPage, void (WTF::String const&)>(IPC::Connection&, IPC::Decoder&, WebKit::WebPage*, void (WebKit::WebPage::*)(WTF::String const&))
23  0x11992c8cc WebKit::WebPage::didReceiveMessage(IPC::Connection&, IPC::Decoder&)
24  0x119902a6c IPC::MessageReceiverMap::dispatchMessage(IPC::Connection&, IPC::Decoder&)
25  0x11cd7758c WebKit::AuxiliaryProcess::dispatchMessage(IPC::Connection&, IPC::Decoder&)
26  0x11994897c WebKit::AuxiliaryProcess::didReceiveMessage(IPC::Connection&, IPC::Decoder&)
27  0x11992282c WebKit::WebProcess::didReceiveMessage(IPC::Connection&, IPC::Decoder&)
28  0x11e9e964c IPC::Connection::dispatchMessage(IPC::Decoder&)
29  0x11e9e9b84 IPC::Connection::dispatchMessage(WTF::UniqueRef<IPC::Decoder>)
30  0x1199570fc IPC::Connection::dispatchOneIncomingMessage()
31  0x11ea4a1e4 IPC::Connection::enqueueIncomingMessage(WTF::UniqueRef<IPC::Decoder>)::$_1::operator()() const
com.apple.WebKit.WebContent.Development terminated (pid 68249) for reason: crash

[Radar WebKit Bug Importer]

<rdar://problem/173722593>

[Anuj Panta]

Pull request: https://github.com/WebKit/WebKit/pull/63276

[EWS]

Committed 311811@main (9fcb2bb3c70e): <https://commits.webkit.org/311811@main>

Reviewed commits have been landed. Closing PR #63276 and removing active labels.