RESOLVED FIXED311037
[GTK] SkImage leaked in webkit_favicon_database_get_favicon_finish() 
https://bugs.webkit.org/show_bug.cgi?id=311037
Summary [GTK] SkImage leaked in webkit_favicon_database_get_favicon_finish()
Adrian Perez
Reported 2026-03-29 15:26:43 PDT
The result from obtaining the image is a SkImage obtaibed with g_task_propagate_pointer(), which gives us ownership of the resulting SkImage; but the SkImage is never unreffed. The SkImage gets converted either into a GdkTexture or a cairo_surface_t; and the helper functions used for this (skiaImageToGdkTexture and skiaImageToCairoSurface) both add their own ref to the SkImage -- that is, the ref obtained from g_task_propagate_pointer() is NOT moved. Therefore, we need to make sure to adopt the ref we obtain from g_task_propagate_pointer() to avoid leaking the SkImage.
Attachments
Add attachment proposed patch, testcase, etc.
Adrian Perez
Comment 1 2026-03-29 15:31:52 PDT
Pull request: https://github.com/WebKit/WebKit/pull/61631
EWS
Comment 2 2026-03-29 22:59:45 PDT
Committed 310202@main (1729470dcaa6): <https://commits.webkit.org/310202@main> Reviewed commits have been landed. Closing PR #61631 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.