Bug 31094 - wrong expected images after Bug 8736
Summary: wrong expected images after Bug 8736
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2009-11-03 19:21 PST by Shinichiro Hamaji
Modified: 2009-11-09 20:09 PST (History)
1 user (show)

See Also:

Patch v1 (1.87 KB, patch)
2009-11-03 19:22 PST, Shinichiro Hamaji
no flags Details | Formatted Diff | Diff
Patch with binary (63.48 KB, patch)
2009-11-03 23:37 PST, Shinichiro Hamaji
eric: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Comment 1 Shinichiro Hamaji 2009-11-03 19:22:36 PST
Created attachment 42442 [details]
Patch v1
Comment 2 Alexey Proskuryakov 2009-11-03 23:18:04 PST
Comment on attachment 42442 [details]
Patch v1

The patch doesn't include diffs to images. I know this works with svn-create-patch when using Subversion.
Comment 3 Shinichiro Hamaji 2009-11-03 23:37:48 PST
Created attachment 42455 [details]
Patch with binary

Yeah, I think this is the downside of git... (I guess bugzilla-tool post-commit doesn't create binary patch because we cannot handle git binary patches by svn-apply) Anyway, I re-uploaded the patch using SVN.
Comment 4 Shinichiro Hamaji 2009-11-03 23:51:08 PST
Ah, bugzilla knows how to handle SVN binary patch... OK, from next time, I'll post SVN style patches if my patch contains binaries.
Comment 5 Eric Seidel (no email) 2009-11-05 15:37:52 PST
We really need to fix svn-apply to know how to deal with binary patches.  Then we can easily change the one line necessary in scm.py to make bugzilla-tool upload binary patches.
Comment 6 Eric Seidel (no email) 2009-11-09 17:48:39 PST
Comment on attachment 42455 [details]
Patch with binary

Comment 7 Shinichiro Hamaji 2009-11-09 20:09:19 PST
Committed r50710: <http://trac.webkit.org/changeset/50710>