From Adam: File "/Users/abarth/git/webkit/WebKitTools/Scripts/modules/bugzilla.py", line 227, in _validate_setter_email log("Warning, attachment %s on bug %s has invalid %s (%s)", (patch['id'], patch['bug_id'], result_key, setter_email)) TypeError: log() takes exactly 1 argument (2 given) Fix coming up.
Created attachment 42436 [details] Patch
Comment on attachment 42436 [details] Patch Sorry, I should have caught that in an earlier code review, I'm sure.
Comment on attachment 42436 [details] Patch Rejecting patch 42436 from commit-queue. Failed to run "['git', 'svn', 'dcommit']" exit_code: 1 Last 500 characters of output: tting to http://svn.webkit.org/repository/webkit/trunk ... M WebKitTools/ChangeLog M WebKitTools/Scripts/modules/bugzilla.py A repository hook failed: MERGE request failed on '/repository/webkit/trunk': Commit blocked by pre-commit hook (exit code 1) with output: svnlook: Can't write to stream: Broken pipe The following ChangeLog files contain OOPS: trunk/WebKitTools/ChangeLog Please don't ever say "OOPS" in a ChangeLog file. at /usr/local/libexec/git-core//git-svn line 469
svn-apply (and thus the commit-queue) can't handle this diff due to bug 30683. Hopefully that will land soon, otherwise I can land this manually.
Comment on attachment 42436 [details] Patch Try again now that bug 30683 is in the queue to be landed.
Strange. Now that bug 30683 is fixed, this should land correctly. I'll investigate.
Comment on attachment 42436 [details] Patch bugzilla-tool apply-patches worked just fine, so I assume the commit-queue's svn-apply just hadn't been updated yet when I last queued this. We'll try on last time.
Comment on attachment 42436 [details] Patch Clearing flags on attachment: 42436 Committed r50602: <http://trac.webkit.org/changeset/50602>
All reviewed patches have been landed. Closing bug.