Bug 310915 – [GTK] [2.52.1] WebKitDOMDOMWindow.cpp:1085:10: error: variable has incomplete type 'void'

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Alberto Garcia]

In file included from build-gtk3/DerivedSources/WebKit/unified-sources/UnifiedSource-54928a2b-18.cpp:5:
Source/WebKit/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMDOMWindow.cpp:1085:10: error: variable has incomplete type 'void'
 1085 |     auto result = handler->postMessage(*globalObject, toJS(globalObject, jsStringValue), adoptRef(*(promise.leakRef())));
      |          ^

This is a build failure caused by this cherry-pick: https://commits.webkit.org/305877.279@webkitglib/2.52

In short, this makes UserMessageHandler::postMessage() return void instead of ExceptionOr<void>, but the caller still expects the latter, and it actually uses the returned value to decide whether to return TRUE or FALSE.

[Adrian Perez]

Pull request: https://github.com/WebKit/WebKit/pull/61521