Bug 31091 – commit-queue is crashing when trying to reject patches after unknown failures

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Eric Seidel (no email)]

commit-queue is crashing when trying to reject patches after unknown failures

Traceback (most recent call last):
  File "WebKitTools/Scripts/bugzilla-tool", line 917, in <module>
    main()
  File "WebKitTools/Scripts/bugzilla-tool", line 914, in main
    return tool.main()
  File "WebKitTools/Scripts/bugzilla-tool", line 909, in main
    return command_object.execute(command_options, command_args, self)
  File "WebKitTools/Scripts/bugzilla-tool", line 762, in execute
    tool.bugs.reject_patch_from_commit_queue(patch['id'], "Unexpected failure when landing patch!  Please file a bug against bugzilla-tool.\n%s" % e.message_with_output())
NameError: global name 'patch' is not defined

This is a really bad place to crash, because we never learn what's actually wrong. :)

I've fixed this.  I also noticed we're leaking file descriptors in this case, so I've fixed that as well.

[Eric Seidel (no email)]

Created attachment 42434 [details]
Patch

[Adam Barth]

Comment on attachment 42434 [details]
Patch

Ok.  I'd prefer to keep the master process as simple as possible to avoid these kinds of bugs in the future.  It should be bullet-proof.

[WebKit Commit Bot]

Comment on attachment 42434 [details]
Patch

Clearing flags on attachment: 42434

Committed r50518: <http://trac.webkit.org/changeset/50518>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.