Bug 31091 - commit-queue is crashing when trying to reject patches after unknown failures
Summary: commit-queue is crashing when trying to reject patches after unknown failures
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-11-03 15:53 PST by Eric Seidel (no email)
Modified: 2009-11-04 10:28 PST (History)
2 users (show)

See Also:


Attachments
Patch (3.27 KB, patch)
2009-11-03 15:57 PST, Eric Seidel (no email)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2009-11-03 15:53:59 PST
commit-queue is crashing when trying to reject patches after unknown failures

Traceback (most recent call last):
  File "WebKitTools/Scripts/bugzilla-tool", line 917, in <module>
    main()
  File "WebKitTools/Scripts/bugzilla-tool", line 914, in main
    return tool.main()
  File "WebKitTools/Scripts/bugzilla-tool", line 909, in main
    return command_object.execute(command_options, command_args, self)
  File "WebKitTools/Scripts/bugzilla-tool", line 762, in execute
    tool.bugs.reject_patch_from_commit_queue(patch['id'], "Unexpected failure when landing patch!  Please file a bug against bugzilla-tool.\n%s" % e.message_with_output())
NameError: global name 'patch' is not defined

This is a really bad place to crash, because we never learn what's actually wrong. :)

I've fixed this.  I also noticed we're leaking file descriptors in this case, so I've fixed that as well.
Comment 1 Eric Seidel (no email) 2009-11-03 15:57:11 PST
Created attachment 42434 [details]
Patch
Comment 2 Adam Barth 2009-11-03 22:57:49 PST
Comment on attachment 42434 [details]
Patch

Ok.  I'd prefer to keep the master process as simple as possible to avoid these kinds of bugs in the future.  It should be bullet-proof.
Comment 3 WebKit Commit Bot 2009-11-04 10:28:47 PST
Comment on attachment 42434 [details]
Patch

Clearing flags on attachment: 42434

Committed r50518: <http://trac.webkit.org/changeset/50518>
Comment 4 WebKit Commit Bot 2009-11-04 10:28:52 PST
All reviewed patches have been landed.  Closing bug.