Bug 31087 - Web Inspector: Timeline should get information about the paint rectangle.
Summary: Web Inspector: Timeline should get information about the paint rectangle.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-11-03 14:49 PST by Kelly Norton
Modified: 2009-11-04 00:42 PST (History)
8 users (show)

See Also:

Attachments
Proposed addition. (4.23 KB, patch)
2009-11-03 14:53 PST, Kelly Norton 		timothy: review-
timothy: commit-queue-
Details | Formatted Diff | Diff
Uses IntRect. (4.78 KB, patch)
2009-11-03 19:18 PST, Kelly Norton 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kelly Norton 2009-11-03 14:49:46 PST 
In the didPaint callback for the Timeline, we should deliver the dimensions of the paint rectangle.
Comment 1 Kelly Norton 2009-11-03 14:53:44 PST 
Created attachment 42422 [details]
Proposed addition.

If this on happens to get r+'d, we probably shouldn't cq+ it quite yet because there are so many other Timeline changes in the cq right now.
Comment 2 Eric Seidel (no email) 2009-11-03 16:29:28 PST 
Comment on attachment 42422 [details]
Proposed addition.

Why wouldn't InspectorTimelineAgent.h use IntRect here?
Comment 3 Kelly Norton 2009-11-03 16:56:40 PST 
(In reply to comment #2)
> (From update of attachment 42422 [details])
> Why wouldn't InspectorTimelineAgent.h use IntRect here?

It definitely could. I was just avoiding the dependency, but I can change that.
Comment 4 Timothy Hatcher 2009-11-03 17:44:34 PST 
Comment on attachment 42422 [details]
Proposed addition.

I agree, use IntRect.
Comment 5 Kelly Norton 2009-11-03 19:18:55 PST 
Created attachment 42441 [details]
Uses IntRect.
Comment 6 WebKit Commit Bot 2009-11-04 00:42:53 PST 
Comment on attachment 42441 [details]
Uses IntRect.

Clearing flags on attachment: 42441

Committed r50502: <http://trac.webkit.org/changeset/50502>
Comment 7 WebKit Commit Bot 2009-11-04 00:42:57 PST 
All reviewed patches have been landed.  Closing bug.