Bug 31082 – Web Inspector - Adds markTimeline() API to the console for annotating the timeline tree

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

This patch adds console.markTimeline() for annotating the timeline tree. This makes it easy for developers to mark application level checkpoints and have them overlaid on the timeline trace tree.

With regards to dealing with calls to this in a loop, I am leaning towards potentially doing message aggregation in the inspector UI.

(patch to be appended to this bug shortly)

Created attachment 42415 [details]
Patch to add console.markTimeline()

[Pavel Feldman]

Comment on attachment 42415 [details]
Patch to add console.markTimeline()

> +{
> +    if (timelineAgent())
> +      timelineAgent()->didMarkTimeline(message);

wrong indent

> +        MarkTimelineRecordType = 11,

will be a conflict with resources events, who gets r+ first? :)

> +    page->inspectorController()->markTimeline(message);

we could pass the stack and try doing .log-alike the formatting, but that is too hard.

r- for indent. otherwise good.

Created attachment 42419 [details]
Fixes indenting in previous patch

[WebKit Commit Bot]

Comment on attachment 42419 [details]
Fixes indenting in previous patch

Rejecting patch 42419 from commit-queue.

Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--quiet', '--exit-after-n-failures=1']" exit_code: 1
Running build-dumprendertree
Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests
Testing 11563 test cases.
fast/dom/Window/window-properties.html -> failed

Exiting early after 1 failures. 5840 tests run.
107.16s total testing time

5839 test cases (99%) succeeded
1 test case (<1%) had incorrect layout
1 test case (<1%) had stderr output

Created attachment 42427 [details]
updates layout test for window properties

Forgot to update a test case. Updated now with this patch.

[WebKit Commit Bot]

Comment on attachment 42427 [details]
updates layout test for window properties

Clearing flags on attachment: 42427

Committed r50501: <http://trac.webkit.org/changeset/50501>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.