Bug 31065 - Web Inspector: Timeline should show resources loading.
Summary: Web Inspector: Timeline should show resources loading.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Kelly Norton
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-11-03 09:24 PST by Kelly Norton
Modified: 2009-11-04 09:17 PST (History)
8 users (show)

See Also:


Attachments
Proposed implementation for resources in the timeline. (11.43 KB, patch)
2009-11-03 12:28 PST, Kelly Norton
no flags Details | Formatted Diff | Diff
Fixes some issues. (11.47 KB, patch)
2009-11-03 13:26 PST, Kelly Norton
timothy: review+
timothy: commit-queue-
Details | Formatted Diff | Diff
Updates and resolves the conflicts. (12.04 KB, patch)
2009-11-04 08:43 PST, Kelly Norton
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kelly Norton 2009-11-03 09:24:58 PST
The default resource tracking has more overhead than is necessary, so the plan is to just add lighter weight callbacks to InspectorTimelineAgent with just enough information to display a pill box on the timeline. If resource tracking is enabled, the UI can use the identifier to cross-link to give users more detail about a particular resource.

(cleaning up a patch now)
Comment 1 Kelly Norton 2009-11-03 12:28:14 PST
Created attachment 42404 [details]
Proposed implementation for resources in the timeline.

Let me know what you guys think of this approach.
Comment 2 Kelly Norton 2009-11-03 13:26:55 PST
Created attachment 42412 [details]
Fixes some issues.
Comment 3 Timothy Hatcher 2009-11-03 17:50:39 PST
Comment on attachment 42412 [details]
Fixes some issues.

I'll land this, since TimelineAgent.js will conflict with another cq+ change.
Comment 4 Kelly Norton 2009-11-04 08:43:11 PST
Created attachment 42485 [details]
Updates and resolves the conflicts.
Comment 5 WebKit Commit Bot 2009-11-04 09:17:22 PST
Comment on attachment 42485 [details]
Updates and resolves the conflicts.

Clearing flags on attachment: 42485

Committed r50515: <http://trac.webkit.org/changeset/50515>
Comment 6 WebKit Commit Bot 2009-11-04 09:17:26 PST
All reviewed patches have been landed.  Closing bug.