Bug 31064 - Web Inspector: Implement timeline summary panel.
Summary: Web Inspector: Implement timeline summary panel.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-11-03 09:21 PST by Pavel Feldman
Modified: 2009-11-03 10:00 PST (History)
4 users (show)

See Also:


Attachments
[PATCH] Proposed patch. (7.18 KB, patch)
2009-11-03 09:28 PST, Pavel Feldman
timothy: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2009-11-03 09:21:40 PST
Patch will follow.
Comment 1 Pavel Feldman 2009-11-03 09:28:20 PST
Created attachment 42389 [details]
[PATCH] Proposed patch.
Comment 2 Timothy Hatcher 2009-11-03 09:46:59 PST
Comment on attachment 42389 [details]
[PATCH] Proposed patch.


> +         // Create sparse arrays 101 cell each to fill with chunks for a given category.

Should be: "Create sparse arrays with 101 cells each…"

> +         // Convert sparse arrays to continues segments, render graphs for each.

Should be "Convert sparse arrays to continuous segments…"

> +        while (this._barAreaElement.firstChild)
> +            this._barAreaElement.removeChild(this._barAreaElement.firstChild);

Just do this._barAreaElement.removeChildren() (from utilities.js)
Comment 3 Pavel Feldman 2009-11-03 09:57:26 PST
(In reply to comment #2)
> (From update of attachment 42389 [details])
> 
> > +         // Create sparse arrays 101 cell each to fill with chunks for a given category.
> 
> Should be: "Create sparse arrays with 101 cells each…"
> 

Done.

> > +         // Convert sparse arrays to continues segments, render graphs for each.
> 
> Should be "Convert sparse arrays to continuous segments…"
> 

Done.

> > +        while (this._barAreaElement.firstChild)
> > +            this._barAreaElement.removeChild(this._barAreaElement.firstChild);
> 
> Just do this._barAreaElement.removeChildren() (from utilities.js)

Done.
Comment 4 Pavel Feldman 2009-11-03 10:00:24 PST
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/inspector/front-end/TimelinePanel.js
	M	WebCore/inspector/front-end/inspector.css
Committed r50463