Bug 31064 – Web Inspector: Implement timeline summary panel.

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Pavel Feldman]

Patch will follow.

[Pavel Feldman]

Created attachment 42389 [details]
[PATCH] Proposed patch.

[Timothy Hatcher]

Comment on attachment 42389 [details]
[PATCH] Proposed patch.


> +         // Create sparse arrays 101 cell each to fill with chunks for a given category.

Should be: "Create sparse arrays with 101 cells each…"

> +         // Convert sparse arrays to continues segments, render graphs for each.

Should be "Convert sparse arrays to continuous segments…"

> +        while (this._barAreaElement.firstChild)
> +            this._barAreaElement.removeChild(this._barAreaElement.firstChild);

Just do this._barAreaElement.removeChildren() (from utilities.js)

[Pavel Feldman]

(In reply to comment #2)
> (From update of attachment 42389 [details])
> 
> > +         // Create sparse arrays 101 cell each to fill with chunks for a given category.
> 
> Should be: "Create sparse arrays with 101 cells each…"
> 

Done.

> > +         // Convert sparse arrays to continues segments, render graphs for each.
> 
> Should be "Convert sparse arrays to continuous segments…"
> 

Done.

> > +        while (this._barAreaElement.firstChild)
> > +            this._barAreaElement.removeChild(this._barAreaElement.firstChild);
> 
> Just do this._barAreaElement.removeChildren() (from utilities.js)

Done.

[Pavel Feldman]

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/inspector/front-end/TimelinePanel.js
	M	WebCore/inspector/front-end/inspector.css
Committed r50463