Bug 31056 - Web Inspector: Implement Timeline Window, wire it to the bottom timeline.
Summary: Web Inspector: Implement Timeline Window, wire it to the bottom timeline.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-11-03 05:42 PST by Pavel Feldman
Modified: 2009-11-03 09:06 PST (History)
4 users (show)

See Also:


Attachments
[IMAGE] Looks with the patch applied. (149.43 KB, image/png)
2009-11-03 05:43 PST, Pavel Feldman
no flags Details
[PATCH] Timeline window. (29.10 KB, patch)
2009-11-03 05:51 PST, Pavel Feldman
timothy: review+
Details | Formatted Diff | Diff
[IMAGE] With overview (144.17 KB, image/png)
2009-11-03 08:47 PST, Pavel Feldman
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2009-11-03 05:42:41 PST
(No summary bars so far).
Comment 1 Pavel Feldman 2009-11-03 05:43:49 PST
Created attachment 42372 [details]
[IMAGE] Looks with the patch applied.
Comment 2 Pavel Feldman 2009-11-03 05:51:20 PST
Created attachment 42373 [details]
[PATCH] Timeline window.
Comment 3 Pavel Feldman 2009-11-03 08:47:25 PST
Created attachment 42386 [details]
[IMAGE] With overview
Comment 4 Timothy Hatcher 2009-11-03 08:51:13 PST
Comment on attachment 42373 [details]
[PATCH] Timeline window.

> +    addExtraDivider: function(divider)
> +    {
> +        this._eventDividersElement.appendChild(divider);
> +    },

This sound be _extraDividersElement if the function is addExtraDivider.


> +        return Number.secondsToString(value + this.minimumBoundary - this._minimumBoundary, WebInspector.UIString.bind(WebInspector));

The "this.minimumBoundary - this._minimumBoundary" line needs clarified. We should renamed _minimumBoundary to mean "minimum boundry ignoring window", maybe add a getter for that too.
Comment 5 Pavel Feldman 2009-11-03 09:03:10 PST
(In reply to comment #4)
> (From update of attachment 42373 [details])
> > +    addExtraDivider: function(divider)
> > +    {
> > +        this._eventDividersElement.appendChild(divider);
> > +    },
> 
> This sound be _extraDividersElement if the function is addExtraDivider.
> 

Renamed method instead.

> 
> > +        return Number.secondsToString(value + this.minimumBoundary - this._minimumBoundary, WebInspector.UIString.bind(WebInspector));
> 
> The "this.minimumBoundary - this._minimumBoundary" line needs clarified. We
> should renamed _minimumBoundary to mean "minimum boundry ignoring window",
> maybe add a getter for that too.

renamed to absoluteMinimumBoundary.
Comment 6 Timothy Hatcher 2009-11-03 09:04:41 PST
(In reply to comment #5)
> (In reply to comment #4)
> > (From update of attachment 42373 [details] [details])
> > > +    addExtraDivider: function(divider)
> > > +    {
> > > +        this._eventDividersElement.appendChild(divider);
> > > +    },
> > 
> > This sound be _extraDividersElement if the function is addExtraDivider.
> > 
> 
> Renamed method instead.
> 
> > 
> > > +        return Number.secondsToString(value + this.minimumBoundary - this._minimumBoundary, WebInspector.UIString.bind(WebInspector));
> > 
> > The "this.minimumBoundary - this._minimumBoundary" line needs clarified. We
> > should renamed _minimumBoundary to mean "minimum boundry ignoring window",
> > maybe add a getter for that too.
> 
> renamed to absoluteMinimumBoundary.

Sounds good.
Comment 7 Pavel Feldman 2009-11-03 09:06:44 PST
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/English.lproj/localizedStrings.js
	M	WebCore/inspector/front-end/AbstractTimelinePanel.js
	M	WebCore/inspector/front-end/ResourcesPanel.js
	M	WebCore/inspector/front-end/TimelinePanel.js
	M	WebCore/inspector/front-end/inspector.css
Committed r50458