(No summary bars so far).
Created attachment 42372 [details] [IMAGE] Looks with the patch applied.
Created attachment 42373 [details] [PATCH] Timeline window.
Created attachment 42386 [details] [IMAGE] With overview
Comment on attachment 42373 [details] [PATCH] Timeline window. > + addExtraDivider: function(divider) > + { > + this._eventDividersElement.appendChild(divider); > + }, This sound be _extraDividersElement if the function is addExtraDivider. > + return Number.secondsToString(value + this.minimumBoundary - this._minimumBoundary, WebInspector.UIString.bind(WebInspector)); The "this.minimumBoundary - this._minimumBoundary" line needs clarified. We should renamed _minimumBoundary to mean "minimum boundry ignoring window", maybe add a getter for that too.
(In reply to comment #4) > (From update of attachment 42373 [details]) > > + addExtraDivider: function(divider) > > + { > > + this._eventDividersElement.appendChild(divider); > > + }, > > This sound be _extraDividersElement if the function is addExtraDivider. > Renamed method instead. > > > + return Number.secondsToString(value + this.minimumBoundary - this._minimumBoundary, WebInspector.UIString.bind(WebInspector)); > > The "this.minimumBoundary - this._minimumBoundary" line needs clarified. We > should renamed _minimumBoundary to mean "minimum boundry ignoring window", > maybe add a getter for that too. renamed to absoluteMinimumBoundary.
(In reply to comment #5) > (In reply to comment #4) > > (From update of attachment 42373 [details] [details]) > > > + addExtraDivider: function(divider) > > > + { > > > + this._eventDividersElement.appendChild(divider); > > > + }, > > > > This sound be _extraDividersElement if the function is addExtraDivider. > > > > Renamed method instead. > > > > > > + return Number.secondsToString(value + this.minimumBoundary - this._minimumBoundary, WebInspector.UIString.bind(WebInspector)); > > > > The "this.minimumBoundary - this._minimumBoundary" line needs clarified. We > > should renamed _minimumBoundary to mean "minimum boundry ignoring window", > > maybe add a getter for that too. > > renamed to absoluteMinimumBoundary. Sounds good.
Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/English.lproj/localizedStrings.js M WebCore/inspector/front-end/AbstractTimelinePanel.js M WebCore/inspector/front-end/ResourcesPanel.js M WebCore/inspector/front-end/TimelinePanel.js M WebCore/inspector/front-end/inspector.css Committed r50458