RESOLVED FIXED31055
Windows nightlies crash on launch: fixed IDL doesn't take effect 
https://bugs.webkit.org/show_bug.cgi?id=31055
Summary Windows nightlies crash on launch: fixed IDL doesn't take effect
808caaa4.8ce9.9cd6c799e9f6
Reported 2009-11-03 05:17:43 PST
related: bug 30938 Windows nightlies **still** crash on launch due to wrong-ordered IWebFramePrivate vtable. This mush be fixed in r50316, but seems no effect **on final binary.** Verified with r50419 buildbot-output available on the web today. --- [WebKit-SVN-r50419.zip/WebKit.dll] ???_7WebFrame@@6BIWebFramePrivate@@@ ; .rdata:104CEA88 dd offset ?QueryInterface@WebFrame@@... dd offset ?AddRef@WebFrame@@... dd offset ?Release@WebFrame@@... dd offset ?renderTreeAsExternalRepresentation@WebFrame@@... dd offset ?counterValueForElementById@WebFrame@@... dd offset ?scrollOffset@WebFrame@@... dd offset ?layout@WebFrame@@... dd offset ?firstLayoutDone@WebFrame@@... dd offset ?loadType@WebFrame@@... dd offset ?setInPrintingMode@WebFrame@@... dd offset ?getPrintedPageCount@WebFrame@@... dd offset ?spoolPages@WebFrame@@... dd offset ?isFrameSet@WebFrame@@... dd offset ?string@WebFrame@@... dd offset ?size@WebFrame@@... dd offset ?hasScrollBars@WebFrame@@... dd offset ?contentBounds@WebFrame@@... dd offset ?frameBounds@WebFrame@@... dd offset ?isDescendantOfFrame@WebFrame@@... dd offset ?pendingFrameUnloadEventCount@WebFrame@@... dd offset ?fetchApplicationIcon@WebFrame@@... dd offset ?paintDocumentRectToContext@WebFrame@@... dd offset ?elementDoesAutoComplete@WebFrame@@... dd offset ?pauseAnimation@WebFrame@@... dd offset ?pauseTransition@WebFrame@@... dd offset ?numberOfActiveAnimations@WebFrame@@... dd offset ?isDisplayingStandaloneImage@WebFrame@@... dd offset ?allowsFollowingLink@WebFrame@@... dd offset ?stringByEvaluatingJavaScriptInIsolatedWorld@... dd offset ?contextForWorldID@WebFrame@@... ---
Attachments
Add attachment proposed patch, testcase, etc.
Adam Roben (:aroben)
Comment 1 2009-11-03 13:55:13 PST
I guess we should touch WebKit.idl.
Brian Weinstein
Comment 2 2009-11-03 14:34:41 PST
Touched WebKit.idl in http://trac.webkit.org/changeset/50484, this should fix it.
Note You need to log in before you can comment on or make changes to this bug.