Bug 31052 - Web Inspector: Prepare for heap profiles upstreaming
Summary: Web Inspector: Prepare for heap profiles upstreaming
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-11-03 04:55 PST by Mikhail Naganov
Modified: 2009-11-03 09:47 PST (History)
4 users (show)

See Also:


Attachments
proposed change (4.54 KB, patch)
2009-11-03 04:57 PST, Mikhail Naganov
pfeldman: review-
Details | Formatted Diff | Diff
proposed change, comments addressed (4.98 KB, patch)
2009-11-03 06:55 PST, Mikhail Naganov
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mikhail Naganov 2009-11-03 04:55:25 PST
Add new functionality by deleting some code ;)

- pass profile type id from InspectorController;
- this makes WebInspector.CPUProfile redundant---removed;
- support multiple profile types when populating profiles.
Comment 1 Mikhail Naganov 2009-11-03 04:57:13 PST
Created attachment 42367 [details]
proposed change
Comment 2 Pavel Feldman 2009-11-03 06:34:22 PST
Comment on attachment 42367 [details]
proposed change

> -    this.panels.profiles.addProfileHeader(WebInspector.CPUProfileType.TypeId, new WebInspector.CPUProfile(profile));
> +    this.panels.profiles.addProfileHeader(profile.typeId, profile);

If every profile has typeId from now on, should we pass single argument here?
Comment 3 Mikhail Naganov 2009-11-03 06:55:56 PST
Created attachment 42378 [details]
proposed change, comments addressed
Comment 4 WebKit Commit Bot 2009-11-03 09:47:48 PST
Comment on attachment 42378 [details]
proposed change, comments addressed

Clearing flags on attachment: 42378

Committed r50460: <http://trac.webkit.org/changeset/50460>
Comment 5 WebKit Commit Bot 2009-11-03 09:47:52 PST
All reviewed patches have been landed.  Closing bug.