Bug 31045 - REGRESSION (r48573): JSC may incorrectly cache chain lookups with a dictionary at the head of the chain
Summary: REGRESSION (r48573): JSC may incorrectly cache chain lookups with a dictionar...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2009-11-02 22:12 PST by Oliver Hunt
Modified: 2009-11-03 11:20 PST (History)
2 users (show)

See Also:


Attachments
fixeration -- haven't yet done a full build so no new expected results yet (5.16 KB, patch)
2009-11-02 22:20 PST, Oliver Hunt
barraclough: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Oliver Hunt 2009-11-02 22:12:56 PST
Tracking bug
<rdar://problem/7358358>
Comment 1 Oliver Hunt 2009-11-02 22:20:04 PST
Created attachment 42362 [details]
fixeration -- haven't yet done a full build so no new expected results yet
Comment 2 Gavin Barraclough 2009-11-02 22:29:18 PST
Comment on attachment 42362 [details]
fixeration -- haven't yet done a full build so no new expected results yet

r is me.
Comment 3 Oliver Hunt 2009-11-02 22:51:26 PST
Committed r50443
Comment 4 Geoffrey Garen 2009-11-03 11:13:43 PST
Shouldn't the isDictionary() tests be isUncacheableDictionary() tests?
Comment 5 Geoffrey Garen 2009-11-03 11:18:31 PST
> Shouldn't the isDictionary() tests be isUncacheableDictionary() tests?

No, I guess not, since a dictionary base could acquire a property that had previously been resolved on a prototype.
Comment 6 Geoffrey Garen 2009-11-03 11:19:20 PST
r=me too.
Comment 7 Oliver Hunt 2009-11-03 11:19:37 PST
(In reply to comment #5)
> > Shouldn't the isDictionary() tests be isUncacheableDictionary() tests?
> 
> No, I guess not, since a dictionary base could acquire a property that had
> previously been resolved on a prototype.

exactly
Comment 8 Geoffrey Garen 2009-11-03 11:20:30 PST
Might be worth verifying that the SNES benchmark didn't regress.