Bug 31030 - Web Inspector: Timeline instrumentation for Node::dispatchGenericEvent missed a case.
Summary: Web Inspector: Timeline instrumentation for Node::dispatchGenericEvent missed...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-11-02 13:35 PST by Kelly Norton
Modified: 2009-11-02 14:02 PST (History)
8 users (show)

See Also:


Attachments
Proposed fix. (2.63 KB, patch)
2009-11-02 13:42 PST, Kelly Norton
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kelly Norton 2009-11-02 13:35:17 PST
This one is my bad. When I filtered out events with no listeners, I forgot to add support for DOMWindow dispatch. This only effects DOM events that are delivered to window (like 'click').

So we current miss this case:
window.addEventListener('click', function(e) { }, false);

Patch is ready, I'm about to upload.
Comment 1 Kelly Norton 2009-11-02 13:42:50 PST
Created attachment 42340 [details]
Proposed fix.
Comment 2 WebKit Commit Bot 2009-11-02 14:02:40 PST
Comment on attachment 42340 [details]
Proposed fix.

Clearing flags on attachment: 42340

Committed r50428: <http://trac.webkit.org/changeset/50428>
Comment 3 WebKit Commit Bot 2009-11-02 14:02:44 PST
All reviewed patches have been landed.  Closing bug.