RESOLVED FIXED310290
Remove CSSToLengthConversionData::computedLineHeightForFontUnits 
https://bugs.webkit.org/show_bug.cgi?id=310290
Summary Remove CSSToLengthConversionData::computedLineHeightForFontUnits
Vitor Roriz
Reported 2026-03-19 10:24:59 PDT
The only call site for computedLineHeightForFontUnits is in the lh unit resolution else branch, which is only reached when \!computingFontSize(). This means the computingFontSize() branch inside computedLineHeightForFontUnits is dead code, and the method always reduces to style()->computedLineHeight(). Therefore, we can call that directly and remove computedLineHeightForFontUnits.
Attachments
Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2026-03-19 10:25:08 PDT
<rdar://problem/172928233>
Vitor Roriz
Comment 2 2026-03-19 10:28:29 PDT
Pull request: https://github.com/WebKit/WebKit/pull/60944
EWS
Comment 3 2026-03-19 12:01:02 PDT
Committed 309569@main (db430c54ab45): <https://commits.webkit.org/309569@main> Reviewed commits have been landed. Closing PR #60944 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.