WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
31028
[gtk] Use gst_element_class_set_details_simple()
https://bugs.webkit.org/show_bug.cgi?id=31028
Summary
[gtk] Use gst_element_class_set_details_simple()
Benjamin Otte
Reported
2009-11-02 12:36:13 PST
Created
attachment 42337
[details]
patch Cosmetic change, just code simplification
Attachments
patch
(2.43 KB, patch)
2009-11-02 12:36 PST
,
Benjamin Otte
jmalonzo
: review+
commit-queue
: commit-queue-
Details
Formatted Diff
Diff
patch v2
(2.29 KB, patch)
2009-11-03 23:41 PST
,
Benjamin Otte
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Jan Alonzo
Comment 1
2009-11-03 01:58:46 PST
Comment on
attachment 42337
[details]
patch Ok. r=me.
WebKit Commit Bot
Comment 2
2009-11-03 02:08:16 PST
Comment on
attachment 42337
[details]
patch Rejecting patch 42337 from commit-queue. Failed to run "['git', 'svn', 'dcommit']" exit_code: 1 Last 500 characters of output: to
http://svn.webkit.org/repository/webkit/trunk
... M WebCore/ChangeLog M WebCore/platform/graphics/gtk/VideoSinkGStreamer.cpp A repository hook failed: MERGE request failed on '/repository/webkit/trunk': Commit blocked by pre-commit hook (exit code 1) with output: svnlook: Can't write to stream: Broken pipe The following ChangeLog files contain OOPS: trunk/WebCore/ChangeLog Please don't ever say "OOPS" in a ChangeLog file. at /usr/local/libexec/git-core//git-svn line 469
Eric Seidel (no email)
Comment 3
2009-11-03 12:03:07 PST
This rejection was caused by
bug 30683
. A fix is up for review but hasn't been landed yet. Until it's fixed diffs need to start from line 1, this one starts from a later line and svn-apply gets confused.
Benjamin Otte
Comment 4
2009-11-03 23:41:54 PST
Created
attachment 42456
[details]
patch v2 This time with a (hopefully) fixed ChangeLog.
WebKit Commit Bot
Comment 5
2009-11-04 00:58:17 PST
Comment on
attachment 42456
[details]
patch v2 Clearing flags on attachment: 42456 Committed
r50504
: <
http://trac.webkit.org/changeset/50504
>
WebKit Commit Bot
Comment 6
2009-11-04 00:58:22 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug