Bug 31026 – [cairo] Remove old workaround from pre-CAIRO_EXTEND_PAD days

• Status: RESOLVED
• Resolution: DUPLICATE
• Component: Platform

[Benjamin Otte]

Back when CAIRO_EXTEND_PAD was not implemented the code used CAIRO_FILTER_NEAREST to avoid a gradient effect at image borders. This patch uses CAIRO_EXTEND_PAD and restores bilinear scaling for images. It also bumps the required Cairo version to 1.6 as CAIRO_EXTEND_PAD was implemented there.

https://bugs.webkit.org/show_bug.cgi?id=14017

[Benjamin Otte]

Created attachment 42335 [details]
patch

[Dirk Schulze]

If you(In reply to comment #1)
> Created an attachment (id=42335) [details]
> patch

If you force Cairo 1.6 as minimum, you could delete the #ifdefs in PathCairo and GraphicsContextCairo as well. And I thnk that we use the webkit coding style on the cairo bits too. So no break between cairo_pattern_set_extend and the brace. I also think that this is a duplication of bug 19266 , right?

[Benjamin Otte]

(In reply to comment #2)
> If you force Cairo 1.6 as minimum, you could delete the #ifdefs in PathCairo
> and GraphicsContextCairo as well. And I thnk that we use the webkit coding
> style on the cairo bits too. So no break between cairo_pattern_set_extend and
> the brace. I also think that this is a duplication of bug 19266 , right?
>
Will do, will fix, yes.

*** This bug has been marked as a duplicate of bug 19266 ***