Bug 31025 - Installation of GIR files doesn't respect --prefix option
Summary: Installation of GIR files doesn't respect --prefix option
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-11-02 11:54 PST by Estêvão Samuel Procópio Amaral
Modified: 2009-11-02 14:26 PST (History)
1 user (show)

See Also:


Attachments
Patch to use --prefix path in GITDIR and GITTYPELIBDIR (1.40 KB, patch)
2009-11-02 11:57 PST, Estêvão Samuel Procópio Amaral
gustavo: review-
Details | Formatted Diff | Diff
Tabless patch to use --prefix path in GITDIR and GITTYPELIBDIR (1.40 KB, patch)
2009-11-02 13:48 PST, Estêvão Samuel Procópio Amaral
no flags Details | Formatted Diff | Diff
Patch to use --prefix path in GITDIR and GITTYPELIBDIR (1.49 KB, patch)
2009-11-02 14:12 PST, Estêvão Samuel Procópio Amaral
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Estêvão Samuel Procópio Amaral 2009-11-02 11:54:32 PST
When you build WebKit with --prefix=/som/path and --enable-introspection, the configure.ac file doesn't use the defined prefix path when asking pkg-config for the path of GIRDIR and GIRTYPELIBDIR.
Comment 1 Estêvão Samuel Procópio Amaral 2009-11-02 11:57:24 PST
Created attachment 42331 [details]
Patch to use --prefix path in GITDIR and GITTYPELIBDIR
Comment 2 Gustavo Noronha (kov) 2009-11-02 13:42:36 PST
Comment on attachment 42331 [details]
Patch to use --prefix path in GITDIR and GITTYPELIBDIR

> +        Reviewed by NOBODY (OOPS!).
> +
> +        Bug 31025 - make install wasn't respecting --prefix option for gobject-
> +	introspection files. (https://bugs.webkit.org/show_bug.cgi?id=31025)

There seems to be a tab here. Only spaces are allowed. If you're using emacs select this paragraph and do a M-x untabity, please =).
Comment 3 Estêvão Samuel Procópio Amaral 2009-11-02 13:48:43 PST
Created attachment 42341 [details]
Tabless patch to use --prefix path in GITDIR and GITTYPELIBDIR

Tabs removed from ChangeLog
Comment 4 Estêvão Samuel Procópio Amaral 2009-11-02 14:12:10 PST
Created attachment 42343 [details]
Patch to use --prefix path in GITDIR and GITTYPELIBDIR

Adjusting ChangeLog to meet WebKit converntion
Comment 5 Gustavo Noronha (kov) 2009-11-02 14:13:27 PST
Comment on attachment 42343 [details]
Patch to use --prefix path in GITDIR and GITTYPELIBDIR

Thanks for the patch.
Comment 6 WebKit Commit Bot 2009-11-02 14:26:08 PST
Comment on attachment 42343 [details]
Patch to use --prefix path in GITDIR and GITTYPELIBDIR

Clearing flags on attachment: 42343

Committed r50430: <http://trac.webkit.org/changeset/50430>
Comment 7 WebKit Commit Bot 2009-11-02 14:26:12 PST
All reviewed patches have been landed.  Closing bug.