Bug 31017 - media/video-currentTime-set.html uses too short of a timeout
Summary: media/video-currentTime-set.html uses too short of a timeout
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-11-02 10:15 PST by Andrew Scherkus
Modified: 2009-11-02 10:53 PST (History)
2 users (show)

See Also:


Attachments
Round 1 (1.24 KB, patch)
2009-11-02 10:17 PST, Andrew Scherkus
no flags Details | Formatted Diff | Diff
Round 1 + Better ChangeLog (1.36 KB, patch)
2009-11-02 10:19 PST, Andrew Scherkus
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Scherkus 2009-11-02 10:15:48 PST
Eric and I discussed in #webkit a while back that some tests use too short of a timeout and end the test too early.

This would be one of them :)

I'm sure there are more, but verifying that the cause of flaky test failures is indeed a timeout and not some other bug is a tricky and time consuming process.
Comment 1 Andrew Scherkus 2009-11-02 10:17:14 PST
Created attachment 42323 [details]
Round 1
Comment 2 Andrew Scherkus 2009-11-02 10:19:23 PST
Created attachment 42324 [details]
Round 1 + Better ChangeLog

Forgot to mention the call to logResult() was fixed.
Comment 3 Eric Carlson 2009-11-02 10:34:34 PST
Comment on attachment 42324 [details]
Round 1 + Better ChangeLog

r=me
Comment 4 WebKit Commit Bot 2009-11-02 10:53:06 PST
Comment on attachment 42324 [details]
Round 1 + Better ChangeLog

Clearing flags on attachment: 42324

Committed r50420: <http://trac.webkit.org/changeset/50420>
Comment 5 WebKit Commit Bot 2009-11-02 10:53:11 PST
All reviewed patches have been landed.  Closing bug.