Bug 31005 - Latest WebKit build (= r50383 ) breaks the WebGL Interface
Summary: Latest WebKit build (= r50383 ) breaks the WebGL Interface
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Critical
Assignee: Nobody
URL: http://webkit.org/blog/603/webgl-now-...
Keywords:
Depends on:
Blocks:
 
Reported: 2009-11-02 02:08 PST by jbehr
Modified: 2009-11-06 16:56 PST (History)
3 users (show)

See Also:


Attachments
Patch with revised test cases (13.03 KB, patch)
2009-11-02 15:26 PST, Chris Marrin
oliver: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description jbehr 2009-11-02 02:08:25 PST
The latest build (= 50383) breaks the WebGL Interface. The Object and Exception structure do not match anymore.

Even the demos (with textures ) on the webkit.org do not work anymore 

Breaks also the x3dom project

http://webkit.org/blog-files/webgl/SpiritBox.html
http://webkit.org/blog/603/webgl-now-available-in-webkit-nightlies/

http://www.x3dom.org

regards
johannes
Comment 1 Chris Marrin 2009-11-02 13:09:58 PST
Looks like the new checks are not handling the unbind case (passing 0 in place of the buffer pointer). Easy to fix...
Comment 2 Chris Marrin 2009-11-02 15:26:20 PST
Created attachment 42347 [details]
Patch with revised test cases

I revised the test cases so they work under the new rules. I am also now always passing valid flags to all the binding functions. This ensures that we are always testing the error condition and it does not get hidden by a parameter validation error.
Comment 3 Oliver Hunt 2009-11-02 15:28:54 PST
Comment on attachment 42347 [details]
Patch with revised test cases

r=me
Comment 4 Chris Marrin 2009-11-02 16:04:51 PST
Sending        LayoutTests/ChangeLog
Sending        LayoutTests/fast/canvas/webgl/incorrect-context-object-behaviour-expected.txt
Sending        LayoutTests/fast/canvas/webgl/null-object-behaviour-expected.txt
Sending        LayoutTests/fast/canvas/webgl/script-tests/incorrect-context-object-behaviour.js
Sending        LayoutTests/fast/canvas/webgl/script-tests/null-object-behaviour.js
Sending        WebCore/ChangeLog
Sending        WebCore/html/canvas/CanvasRenderingContext3D.cpp
Sending        WebCore/platform/graphics/mac/GraphicsContext3DMac.cpp
Transmitting file data ........
Committed revision 50432.