Bug 31002 - Web Inspector: Add support for window events to Timeline.
Summary: Web Inspector: Add support for window events to Timeline.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-11-01 19:40 PST by Kelly Norton
Modified: 2009-11-03 09:41 PST (History)
8 users (show)

See Also:


Attachments
Proposed change. (8.35 KB, patch)
2009-11-01 19:54 PST, Kelly Norton
no flags Details | Formatted Diff | Diff
Merged window and dom events to the same callbacks. (11.06 KB, patch)
2009-11-01 20:32 PST, Kelly Norton
timothy: review-
Details | Formatted Diff | Diff
Adds missing change to localizedStrings.js (11.30 KB, patch)
2009-11-01 20:43 PST, Kelly Norton
timothy: review-
Details | Formatted Diff | Diff
w/ binary diff. (11.44 KB, patch)
2009-11-01 20:53 PST, Kelly Norton
timothy: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kelly Norton 2009-11-01 19:40:59 PST
Good to see things like onresize on the timeline. patch coming.
Comment 1 Kelly Norton 2009-11-01 19:54:16 PST
Created attachment 42291 [details]
Proposed change.
Comment 2 Kelly Norton 2009-11-01 20:32:34 PST
Created attachment 42292 [details]
Merged window and dom events to the same callbacks.
Comment 3 Timothy Hatcher 2009-11-01 20:39:23 PST
Comment on attachment 42292 [details]
Merged window and dom events to the same callbacks.

You need to update localizableStrings.js for the DOM Event => Event string change.

Otherwise r+.
Comment 4 Kelly Norton 2009-11-01 20:43:08 PST
Created attachment 42294 [details]
Adds missing change to localizedStrings.js
Comment 5 Timothy Hatcher 2009-11-01 20:49:59 PST
Comment on attachment 42294 [details]
Adds missing change to localizedStrings.js

Need to binary diff for localizableStrings.js.
Comment 6 Kelly Norton 2009-11-01 20:53:05 PST
Created attachment 42295 [details]
w/ binary diff.
Comment 7 WebKit Commit Bot 2009-11-01 22:18:06 PST
Comment on attachment 42295 [details]
w/ binary diff.

Rejecting patch 42295 from commit-queue.

Failed to run "['/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', '--reviewer', 'Timothy Hatcher', '--force']" exit_code: 2
Last 500 characters of output:
ile WebCore/ChangeLog
patch: **** Only garbage was found in the patch input.
patching file WebCore/dom/Node.cpp
patching file WebCore/inspector/InspectorTimelineAgent.cpp
patching file WebCore/inspector/InspectorTimelineAgent.h
patching file WebCore/inspector/TimelineRecordFactory.cpp
patching file WebCore/inspector/TimelineRecordFactory.h
patching file WebCore/inspector/front-end/TimelineAgent.js
patching file WebCore/inspector/front-end/TimelinePanel.js
patching file WebCore/page/DOMWindow.cpp
Comment 8 Pavel Feldman 2009-11-02 01:37:51 PST
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/English.lproj/localizedStrings.js
	M	WebCore/dom/Node.cpp
	M	WebCore/inspector/InspectorTimelineAgent.cpp
	M	WebCore/inspector/InspectorTimelineAgent.h
	M	WebCore/inspector/TimelineRecordFactory.cpp
	M	WebCore/inspector/TimelineRecordFactory.h
	M	WebCore/inspector/front-end/TimelineAgent.js
	M	WebCore/inspector/front-end/TimelinePanel.js
	M	WebCore/page/DOMWindow.cpp
Committed r50407
Comment 9 Eric Seidel (no email) 2009-11-03 09:41:39 PST
I believe you hit bug 26830.