Bug 31000 - Windows WebKit Build Configuration should default to Debug instead of Debug_all
Summary: Windows WebKit Build Configuration should default to Debug instead of Debug_all
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows 7
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-11-01 17:25 PST by Jessie Berlin
Modified: 2009-12-17 11:13 PST (History)
3 users (show)

See Also:


Attachments
Remove WebKit.sln's Debug_All and Debug_Internal configurations (18.00 KB, patch)
2009-12-17 08:40 PST, Adam Roben (:aroben)
mitz: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jessie Berlin 2009-11-01 17:25:17 PST
For those trying to build WebKit on Windows for the first time from within Visual Studio, it is confusing that default Build Configuration is set to Debug_all, which will not compile after following the directions for setting up WebKit on Windows, instead of Debug.
Comment 1 Adam Roben (:aroben) 2009-11-02 07:10:07 PST
I'm not even sure why WebKit.sln has Debug_All and Debug_Internal configurations. It is only used for open source builds. Maybe we should just remove those configurations?
Comment 2 Adam Roben (:aroben) 2009-12-17 08:40:41 PST
Created attachment 45074 [details]
Remove WebKit.sln's Debug_All and Debug_Internal configurations
Comment 3 WebKit Review Bot 2009-12-17 08:41:08 PST
style-queue ran check-webkit-style on attachment 45074 [details] without any errors.
Comment 4 mitz 2009-12-17 08:41:57 PST
Comment on attachment 45074 [details]
Remove WebKit.sln's Debug_All and Debug_Internal configurations

rs=me
Comment 5 Adam Roben (:aroben) 2009-12-17 11:13:51 PST
Committed r52263: <http://trac.webkit.org/changeset/52263>