Bug 30999 - Web Inspector: Convert script tag event into a more generic script event in timeline.
Summary: Web Inspector: Convert script tag event into a more generic script event in t...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-11-01 13:55 PST by Pavel Feldman
Modified: 2009-11-02 01:25 PST (History)
3 users (show)

See Also:


Attachments
[PATCH] Proposed change (10.73 KB, patch)
2009-11-01 14:02 PST, Pavel Feldman
timothy: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2009-11-01 13:55:57 PST
That's basically what I suggest doing (will attach the patch shortly). Let us collect pros and cons under this bug.
Comment 1 Pavel Feldman 2009-11-01 14:02:14 PST
Created attachment 42282 [details]
[PATCH] Proposed change
Comment 2 Eric Ayers 2009-11-01 17:37:04 PST
I was thinking this weekend that if we handled the window.eval() with a different event, we'd be able to tell these Script tags apart from window.eval().
Comment 3 Timothy Hatcher 2009-11-01 18:09:30 PST
Right now window.eval isn't handled at all, since it is done directly in JSC.
Comment 4 Pavel Feldman 2009-11-02 01:25:43 PST
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/bindings/js/ScriptController.cpp
	M	WebCore/bindings/v8/V8Proxy.cpp
	M	WebCore/html/HTMLTokenizer.cpp
	M	WebCore/inspector/InspectorTimelineAgent.cpp
	M	WebCore/inspector/InspectorTimelineAgent.h
	M	WebCore/inspector/TimelineRecordFactory.cpp
	M	WebCore/inspector/TimelineRecordFactory.h
	M	WebCore/inspector/front-end/TimelineAgent.js
	M	WebCore/inspector/front-end/TimelinePanel.js
Committed r50406