Bug 30998 – [Gtk] Implement AtkDocument's locale support

• Status: RESOLVED
• Resolution: FIXED
• Component: Accessibility

[Joanmarie Diggs]

Created attachment 42281 [details]
proposed fix

+++ This bug was initially created as a clone of Bug #30964 +++

We need to implement the AtkDocument interface.
http://library.gnome.org/devel/atk/unstable/AtkDocument.html

[Jan Alonzo]

Comment on attachment 42281 [details]
proposed fix

>  static const gchar* webkit_accessible_document_get_locale(AtkDocument* document)
>  {
> -    // FIXME: This needs to be implemented.
> -    notImplemented();
> +
> +    // TODO: Should we fall back on lang xml:lang when the following comes up empty?
> +    String language = static_cast<AccessibilityRenderObject*>(core(document))->language();
> +    if (!language.isEmpty())
> +        return returnString(language);

Should this return NULL if empty?

[Joanmarie Diggs]

(In reply to comment #1)
> (From update of attachment 42281 [details])
> >  static const gchar* webkit_accessible_document_get_locale(AtkDocument* document)
> >  {
> > -    // FIXME: This needs to be implemented.
> > -    notImplemented();
> > +
> > +    // TODO: Should we fall back on lang xml:lang when the following comes up empty?
> > +    String language = static_cast<AccessibilityRenderObject*>(core(document))->language();
> > +    if (!language.isEmpty())
> > +        return returnString(language);
> 
> Should this return NULL if empty?

I think so. Do you think otherwise? Or am I missing something?

-    // FIXME: This needs to be implemented.
-    notImplemented();
+
+    // TODO: Should we fall back on lang xml:lang when the following comes up empty?
+    String language = static_cast<AccessibilityRenderObject*>(core(document))->language();
+    if (!language.isEmpty())
+        return returnString(language);
+
     return 0;
     ^^^^^^^^^

[Jan Alonzo]

Comment on attachment 42281 [details]
proposed fix

>      return 0;

Yup, I missed it. :) r=me.

[WebKit Commit Bot]

Comment on attachment 42281 [details]
proposed fix

Clearing flags on attachment: 42281

Committed r50412: <http://trac.webkit.org/changeset/50412>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.