There are multiple uses of DOM objects in the GraphicsContext3D object which are a significant layering violation. These need to be fixed.
Created attachment 42266 [details] Remove canvas and image element uses from CanvasRenderingContext3D
Created attachment 42267 [details] Remove canvas and image element uses from CanvasRenderingContext3D
Comment on attachment 42267 [details] Remove canvas and image element uses from CanvasRenderingContext3D > + CachedImage* cachedImage = image->cachedImage(); > + if (!cachedImage) > + return; > + m_context->texSubImage2D(target, level, xoffset, yoffset, width, height, cachedImage->image(), flipY, premultiplyAlpha); > cleanupAfterGraphicsCall(false); All the other cases you put a blank line after the early return. r=me
Committed r50394
https://github.com/WebKit/WebKit/commit/966e02e441e1039e708cb9bb54e6c4c11cd7badd and checking by bug number and commit id ‘50394' seems to indicate that it was not backed out. Marking ‘RESOLVED FIXED’.