Bug 30986 - Fix layering violations in GraphicsContext3D
Summary: Fix layering violations in GraphicsContext3D
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Oliver Hunt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-10-31 20:36 PDT by Oliver Hunt
Modified: 2009-11-01 18:12 PST (History)
1 user (show)

See Also:

Attachments
Remove canvas and image element uses from CanvasRenderingContext3D (9.70 KB, patch)
2009-10-31 21:36 PDT, Oliver Hunt 		no flags Details | Formatted Diff | Diff
Remove canvas and image element uses from CanvasRenderingContext3D (9.73 KB, patch)
2009-10-31 21:37 PDT, Oliver Hunt 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Oliver Hunt 2009-10-31 20:36:42 PDT 
There are multiple uses of DOM objects in the GraphicsContext3D object which are a significant layering violation.  These need to be fixed.
Comment 1 Oliver Hunt 2009-10-31 21:36:00 PDT 
Created attachment 42266 [details]
Remove canvas and image element uses from CanvasRenderingContext3D
Comment 2 Oliver Hunt 2009-10-31 21:37:55 PDT 
Created attachment 42267 [details]
Remove canvas and image element uses from CanvasRenderingContext3D
Comment 3 Darin Adler 2009-11-01 13:18:17 PST 
Comment on attachment 42267 [details]
Remove canvas and image element uses from CanvasRenderingContext3D

> +    CachedImage* cachedImage = image->cachedImage();
> +    if (!cachedImage)
> +        return;
> +    m_context->texSubImage2D(target, level, xoffset, yoffset, width, height, cachedImage->image(), flipY, premultiplyAlpha);
>      cleanupAfterGraphicsCall(false);

All the other cases you put a blank line after the early return.

r=me
Comment 4 Oliver Hunt 2009-11-01 18:10:36 PST 
Committed r50394