Bug 30983 - Remove obsolete null checks from CanvasRenderingContext3DMac
Summary: Remove obsolete null checks from CanvasRenderingContext3DMac
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-10-31 15:47 PDT by Oliver Hunt
Modified: 2009-10-31 16:23 PDT (History)
0 users

See Also:


Attachments
Patch (6.93 KB, patch)
2009-10-31 15:48 PDT, Oliver Hunt
no flags Details | Formatted Diff | Diff
Patch (6.95 KB, patch)
2009-10-31 15:58 PDT, Oliver Hunt
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Oliver Hunt 2009-10-31 15:47:46 PDT
As part of my canvas refactoring a large number of null checks in CanvasRenderingContext3DMac become obsolete
Comment 1 Oliver Hunt 2009-10-31 15:48:43 PDT
Created attachment 42261 [details]
Patch
Comment 2 Darin Adler 2009-10-31 15:54:38 PDT
Comment on attachment 42261 [details]
Patch

> +    ASSERT(program && shader);

We should always use multiple assertions instead of an && in an assertion, because that way we can tell which one fails.

The title of this bug does not match the patch. The patch does not remove assertions. It adds assertions and removes unneeded runtime checks.

review- because although the problems with the patch are extremely minor, the benefit of the patch is also minor

Please fix the title and don't use && in assertions.
Comment 3 Oliver Hunt 2009-10-31 15:57:32 PDT
Whoops, yes i am removing null checks :D
Comment 4 Oliver Hunt 2009-10-31 15:58:20 PDT
Created attachment 42262 [details]
Patch
Comment 5 Oliver Hunt 2009-10-31 16:22:51 PDT
Committed r50382