Bug 30980 – Cleanup in wx code: avoid unnecessary wxString::mb_str() calls

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit wx

[Vadim Zeitlin]

Created attachment 42258 [details]
Patch removing unnecessary wxString::mb_str() calls

While debugging the bug 30977 I noticed that in a few places in the code there were ugly-looking explicit conversions between wxString and WebCore::String. They seem to be unnecessary as there is already an implicit ctor in String from wxString so IMO we should be simply using it because just "baseUrl" looks much better than "static_cast<const char*>(baseUrl.mb_str(wxConvUTF8))". So I attach a patch which simply removes these calls.

[Eric Seidel (no email)]

Comment on attachment 42258 [details]
Patch removing unnecessary wxString::mb_str() calls

Please don't remove the Reviewed by NOBODY (OOPS!). line.  That's used by our scripts when landing to fill in who reviewed the patch.

OTherwise this looks fine.  You can post a new patch for use with the commit-queue, or find someone to land this manually for you.

[Vadim Zeitlin]

Created attachment 42476 [details]
Same patch but with "Review" lines preserved.

Sorry for removing these lines, I didn't realize they were necessary. I'm resubmitting exactly the same patch but amended to preserve these lines untouched.

[WebKit Commit Bot]

Comment on attachment 42476 [details]
Same patch but with "Review" lines preserved.

Clearing flags on attachment: 42476

Committed r50516: <http://trac.webkit.org/changeset/50516>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.