Bug 30967 - Give the FrameLoaderClient the ability to override Settings::isJavaScriptEnabled.
Summary: Give the FrameLoaderClient the ability to override Settings::isJavaScriptEnab...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Darin Fisher (:fishd, Google)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-10-30 15:22 PDT by Darin Fisher (:fishd, Google)
Modified: 2009-11-02 21:47 PST (History)
1 user (show)

See Also:


Attachments
v1 patch (4.01 KB, patch)
2009-10-30 15:23 PDT, Darin Fisher (:fishd, Google)
darin: review+
fishd: commit-queue-
Details | Formatted Diff | Diff
v2 patch (5.95 KB, patch)
2009-10-30 15:35 PDT, Darin Fisher (:fishd, Google)
abarth: review+
fishd: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Fisher (:fishd, Google) 2009-10-30 15:22:33 PDT
Give the FrameLoaderClient the ability to override Settings::isJavaScriptEnabled.

I plan to use this to remove ChromiumBridge::uiResourceProtocol() as well as some
other application-specific cruft in V8Proxy.cpp.
Comment 1 Darin Fisher (:fishd, Google) 2009-10-30 15:23:55 PDT
Created attachment 42239 [details]
v1 patch
Comment 2 Adam Barth 2009-10-30 15:29:06 PDT
This looks great, but can't we just delete V8Proxy::isEnabled?  V8Proxy and ScriptContoller are the same thing.
Comment 3 Darin Fisher (:fishd, Google) 2009-10-30 15:31:43 PDT
Yes, I can do that.  I can also remove uiResourceProtocol from ChromiumBridge!
Comment 4 Darin Adler 2009-10-30 15:32:41 PDT
Comment on attachment 42239 [details]
v1 patch

Looks OK. r=me
Comment 5 Darin Fisher (:fishd, Google) 2009-10-30 15:35:24 PDT
Created attachment 42240 [details]
v2 patch
Comment 6 Adam Barth 2009-10-30 16:49:25 PDT
Comment on attachment 42240 [details]
v2 patch

Great!  I like how this patch makes the old code look silly.
Comment 7 Darin Fisher (:fishd, Google) 2009-11-02 21:47:58 PST
Landed as:  http://trac.webkit.org/changeset/50441