RESOLVED FIXED 30952
Patch v1 is a dumb default name for patches 
https://bugs.webkit.org/show_bug.cgi?id=30952
Summary Patch v1 is a dumb default name for patches
Adam Barth
Reported 2009-10-30 01:38:50 PDT
Patch forthcoming.
Attachments
Patch (2.85 KB, patch)
2009-10-30 01:40 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2009-10-30 01:40:37 PDT
Created attachment 42191 [details] Patch
David Kilzer (:ddkilzer)
Comment 2 2009-10-30 03:03:34 PDT
Why is it dumb? The idea was that bugzilla-tool would increment the "v1" to "v2", "v3", etc. as additional patches were attached. This naming also assumes that the first patch isn't always accepted when reviewed and that further patches would be posted.
Adam Barth
Comment 3 2009-10-30 11:07:45 PDT
Comment on attachment 42191 [details] Patch It might make sense to add back the v1 part once we get the version incrementing to work. As it stands, it looks silly to have several patches uploaded to a bug all labeled "v1".
WebKit Commit Bot
Comment 4 2009-10-30 11:19:39 PDT
Comment on attachment 42191 [details] Patch Clearing flags on attachment: 42191 Committed r50346: <http://trac.webkit.org/changeset/50346>
WebKit Commit Bot
Comment 5 2009-10-30 11:19:43 PDT
All reviewed patches have been landed. Closing bug.
David Kilzer (:ddkilzer)
Comment 6 2009-10-30 13:07:10 PDT
(In reply to comment #3) > (From update of attachment 42191 [details]) > It might make sense to add back the v1 part once we get the version > incrementing to work. As it stands, it looks silly to have several patches > uploaded to a bug all labeled "v1". Having several patches all labeled "Patch" is equally as lame as having them all labeled "Patch v1". I would have rather seen you implement that feature rather than back out this change, but whatever.
Note You need to log in before you can comment on or make changes to this bug.