Bug 30948 - Regression: crash enumerating properties of an object with getters or setters
Summary: Regression: crash enumerating properties of an object with getters or setters
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-10-30 00:54 PDT by Oliver Hunt
Modified: 2009-10-30 02:15 PDT (History)
0 users

See Also:

Attachments
Patch v1 (3.83 KB, patch)
2009-10-30 01:03 PDT, Oliver Hunt 		barraclough: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Oliver Hunt 2009-10-30 00:54:19 PDT 
Code inspection showed that enumeration caching doesn't account for the existence of getters or setters.
Comment 1 Oliver Hunt 2009-10-30 01:03:35 PDT 
Created attachment 42180 [details]
Patch v1
Comment 2 Gavin Barraclough 2009-10-30 01:10:36 PDT 
Comment on attachment 42180 [details]
Patch v1

In the über-big if statement, I have a feeling we usually put the && on the continuing line.  Also, might be nicer with one line per clause.
Still, r+ with or without that change.
Comment 3 Oliver Hunt 2009-10-30 01:13:54 PDT 
Committed r50323
Comment 4 Oliver Hunt 2009-10-30 02:15:09 PDT 
Committed r50323