Bug 30943 - [V8] More cleanup after r49949: remove ListenerGuard.
Summary: [V8] More cleanup after r49949: remove ListenerGuard.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Dmitry Titov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-10-29 19:16 PDT by Dmitry Titov
Modified: 2009-10-30 13:13 PDT (History)
2 users (show)

See Also:


Attachments
Proposed patch. (20.72 KB, patch)
2009-10-29 19:21 PDT, Dmitry Titov
dglazkov: review+
dimich: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitry Titov 2009-10-29 19:16:41 PDT
This is remaining cleanup after http://trac.webkit.org/changeset/49949. Since EventListeners are now independent of Frame or V8 context, there is no need to have ListenerGuard that was disabling listeners on window close or navigation.

This enables fast/events/add-event-without-document.html for Chromium.
Run the change through Chromium trybots.
Comment 1 Dmitry Titov 2009-10-29 19:21:18 PDT
Created attachment 42170 [details]
Proposed patch.

Trybot run completed successfully.
Comment 2 Dimitri Glazkov (Google) 2009-10-29 20:38:22 PDT
Comment on attachment 42170 [details]
Proposed patch.

r=me. Gorgeous. Thanks for cleaning up what I should've cleaned up in the first place.
Comment 3 Dmitry Titov 2009-10-30 13:13:57 PDT
Landed: http://trac.webkit.org/changeset/50347