Bug 30939 - counterValueForElementById should return space-separated string for multiple counters
Summary: counterValueForElementById should return space-separated string for multiple ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-10-29 18:34 PDT by Shinichiro Hamaji
Modified: 2009-10-30 10:58 PDT (History)
0 users

See Also:

Attachments
Patch v1 (6.56 KB, patch)
2009-10-29 18:35 PDT, Shinichiro Hamaji 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Shinichiro Hamaji 2009-10-29 18:34:10 PDT 
As Darin suggested in Bug 30555, layoutTestController.counterValueForElementById should return space-separated string when there are multiple counters in one element.
Comment 1 Shinichiro Hamaji 2009-10-29 18:35:57 PDT 
Created attachment 42165 [details]
Patch v1
Comment 2 Darin Adler 2009-10-30 10:14:42 PDT 
Comment on attachment 42165 [details]
Patch v1

> +                stream << " ";

It's probably more efficient to append a space character instead of a single-character string, but efficiency is not critical here.

r=me
Comment 3 Shinichiro Hamaji 2009-10-30 10:32:45 PDT 
> It's probably more efficient to append a space character instead of a
> single-character string, but efficiency is not critical here.

Yeah, I considered it a bit, but I just used the C string because I couldn't find operator<<(char) in TextStream. I think it's not worth adding an overload function.
Comment 4 Shinichiro Hamaji 2009-10-30 10:58:19 PDT 
Committed r50345: <http://trac.webkit.org/changeset/50345>