RESOLVED FIXED309353
[ATSPI] Add missing RenderElementInlines.h to AccessibilityObjectAtspi.cpp 
https://bugs.webkit.org/show_bug.cgi?id=309353
Summary [ATSPI] Add missing RenderElementInlines.h to AccessibilityObjectAtspi.cpp
Lauro Moura
Reported 2026-03-06 09:15:09 PST
While testing PGO and LTO in the WPE build with clang, we had to use `--allow-multiple-definition`, which in turn made linking fail with the following error: FAILED: lib/libWPEWebKit-2.0.so.1.10.0 : && /usr/local/bin/clang++ -fPIC -DASSERT_ENABLED=0 -flto=thin -fdiagnostics-color=always -fcolor-diagnostics -Wextra -Wall -Werror=undefined-internal -Werror=undefined-inline -pipe -Wno-noexcept-type -frelaxed-template-template-args -Wno-nullability-completeness -Wno-psabi -Wno-misleading-indentation -Wno-parentheses-equality -Qunused-arguments -Wundef -Wpointer-arith -Wmissing-format-attribute -Wformat-security -Wcast-align -Wno-tautological-compare -fasynchronous-unwind-tables -fdebug-types-section -fno-omit-frame-pointer -fno-strict-aliasing -fno-exceptions -fno-rtti -fcoroutines -ffunction-sections -fdata-sections -O3 -DNDEBUG -fprofile-generate=/tmp/pgo-profiles -Wl,--allow-multiple-definition -Wl,--no-undefined -flto=thin -L/jhbuild/install/lib -fuse-ld=lld -Wl,--gc-sections -Wl,--disable-new-dtags -shared -Wl,-soname,libWPEWebKit-2.0.so.1 -o lib/libWPEWebKit-2.0.so.1.10.0 @CMakeFiles/WebKit.rsp && : ld.lld: error: undefined symbol: WebCore::RenderElement::isAnonymousBlock() const >>> referenced by UnifiedSource-aba958d6-6.cpp >>> Source/WebCore/CMakeFiles/WebCore.dir/__/__/WebCore/DerivedSources/unified-sources/libWPEWebKit-2.0.so.1.10.0.lto.UnifiedSource-aba958d6-6.cpp.o:(WebCore::AccessibilityObject::accessibilityPlatformIncludesObject() const) Upon closer inspection, AccessibilityObjectAtspi.cpp indeed uses the inline defined in RenderElementInlines.h, without including it directly. Patch incoming.
Attachments
Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2026-03-06 09:15:14 PST
<rdar://problem/171907503>
Lauro Moura
Comment 2 2026-03-06 09:27:42 PST
Pull request: https://github.com/WebKit/WebKit/pull/60069
EWS
Comment 3 2026-03-06 10:25:34 PST
Committed 308810@main (5948fe823902): <https://commits.webkit.org/308810@main> Reviewed commits have been landed. Closing PR #60069 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.