Bug 30918 - Web Inspector: Datagrid Rows on Windows not properly aligned
: Web Inspector: Datagrid Rows on Windows not properly aligned
Status: RESOLVED FIXED
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated)
: 528+ (Nightly build)
: PC Windows 7
: P2 Normal
Assigned To: Brian Weinstein
: PlatformOnly
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-10-29 11:24 PDT by Brian Weinstein
Modified: 2009-10-29 14:25 PDT (History)
6 users (show)

See Also:


Attachments
Screen Shot (92.92 KB, image/png)
2009-10-29 11:24 PDT, Brian Weinstein
no flags Details
Fix (1.85 KB, patch)
2009-10-29 13:35 PDT, Brian Weinstein
bweinstein: commit‑queue-
Details | Formatted Diff | Diff
Fix with better formatting (1.84 KB, patch)
2009-10-29 13:37 PDT, Brian Weinstein
bweinstein: commit‑queue-
Details | Formatted Diff | Diff
Screenshot w/ line-height: 12px (FIXED) (114.60 KB, image/png)
2009-10-29 14:12 PDT, Brian Weinstein
no flags Details
Line-height Fix (1.11 KB, patch)
2009-10-29 14:18 PDT, Brian Weinstein
timothy: review+
bweinstein: commit‑queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brian Weinstein 2009-10-29 11:24:15 PDT
The size of the text != the size of the rows in the data grids on Windows.

On the datagrids I tested, this is true for: Profiling, Local Storage, Session Storage, Cookies.
Comment 1 Brian Weinstein 2009-10-29 11:24:54 PDT
Created attachment 42116 [details]
Screen Shot
Comment 2 Brian Weinstein 2009-10-29 13:35:57 PDT
Created attachment 42131 [details]
Fix
Comment 3 Brian Weinstein 2009-10-29 13:37:24 PDT
Created attachment 42133 [details]
Fix with better formatting
Comment 4 Timothy Hatcher 2009-10-29 14:02:36 PDT
This patch seems fine. But I think the font looks funny (too small) and the line height is too tall. I bet this can be fixed by making the line-height be a fixed height.

Try adding line-height: 12px or 10px (or something) to ".data-grid td".
Comment 5 Brian Weinstein 2009-10-29 14:12:57 PDT
Created attachment 42143 [details]
Screenshot w/ line-height: 12px (FIXED)
Comment 6 Brian Weinstein 2009-10-29 14:18:59 PDT
Created attachment 42144 [details]
Line-height Fix
Comment 7 Brian Weinstein 2009-10-29 14:25:42 PDT
Landed in r50300.