Bug 30918 - Web Inspector: Datagrid Rows on Windows not properly aligned
: Web Inspector: Datagrid Rows on Windows not properly aligned
Status: RESOLVED FIXED
: WebKit
Web Inspector (Deprecated)
: 528+ (Nightly build)
: PC Windows 7
: P2 Normal
Assigned To:
:
: PlatformOnly
:
:
  Show dependency treegraph
 
Reported: 2009-10-29 11:24 PST by
Modified: 2009-10-29 14:25 PST (History)


Attachments
Screen Shot (92.92 KB, image/png)
2009-10-29 11:24 PST, Brian Weinstein
no flags Details
Fix (1.85 KB, patch)
2009-10-29 13:35 PST, Brian Weinstein
bweinstein: commit‑queue-
Review Patch | Details | Formatted Diff | Diff
Fix with better formatting (1.84 KB, patch)
2009-10-29 13:37 PST, Brian Weinstein
bweinstein: commit‑queue-
Review Patch | Details | Formatted Diff | Diff
Screenshot w/ line-height: 12px (FIXED) (114.60 KB, image/png)
2009-10-29 14:12 PST, Brian Weinstein
no flags Details
Line-height Fix (1.11 KB, patch)
2009-10-29 14:18 PST, Brian Weinstein
timothy: review+
bweinstein: commit‑queue-
Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2009-10-29 11:24:15 PST
The size of the text != the size of the rows in the data grids on Windows.

On the datagrids I tested, this is true for: Profiling, Local Storage, Session Storage, Cookies.
------- Comment #1 From 2009-10-29 11:24:54 PST -------
Created an attachment (id=42116) [details]
Screen Shot
------- Comment #2 From 2009-10-29 13:35:57 PST -------
Created an attachment (id=42131) [details]
Fix
------- Comment #3 From 2009-10-29 13:37:24 PST -------
Created an attachment (id=42133) [details]
Fix with better formatting
------- Comment #4 From 2009-10-29 14:02:36 PST -------
This patch seems fine. But I think the font looks funny (too small) and the line height is too tall. I bet this can be fixed by making the line-height be a fixed height.

Try adding line-height: 12px or 10px (or something) to ".data-grid td".
------- Comment #5 From 2009-10-29 14:12:57 PST -------
Created an attachment (id=42143) [details]
Screenshot w/ line-height: 12px (FIXED)
------- Comment #6 From 2009-10-29 14:18:59 PST -------
Created an attachment (id=42144) [details]
Line-height Fix
------- Comment #7 From 2009-10-29 14:25:42 PST -------
Landed in r50300.