Bug 309145 – fast/css/vertical-text-overflow-ellipsis-text-align-center-mixed.html is flaky recently

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Fujii Hironori]

History: https://results.webkit.org/?suite=layout-tests&test=fast%2Fcss%2Fvertical-text-overflow-ellipsis-text-align-center-mixed.html

308378@main is the first failure.

https://build.webkit.org/results/GTK-Linux-64-bit-Release-Tests/308378@main%20(23657)/fast/css/vertical-text-overflow-ellipsis-text-align-center-mixed-diff.txt

--- /sdk/webkit/layout-test-results/fast/css/vertical-text-overflow-ellipsis-text-align-center-mixed-expected.txt
+++ /sdk/webkit/layout-test-results/fast/css/vertical-text-overflow-ellipsis-text-align-center-mixed-actual.txt
@@ -77,14 +77,14 @@
     RenderText {#text} at (55,-387) size 18x696
       text run at (55,-386) width 696 RTL: "em ipsum dolor sit amet, consectetur adipiscing elit. Vivamus vitae eros non libero faucibus sagittis sed ut eros."
     RenderBR {BR} at (55,-387) size 18x1
-layer at (8,2273) size 27x310 clip at (9,2274) size 25x308 scrollY 439 scrollHeight 747
+layer at (8,2273) size 27x310 clip at (9,2274) size 25x308 scrollY 414 scrollHeight 747
   RenderBlock {DIV} at (0,2265) size 27x311 [border: (1px solid #000000)]
     RenderText {#text} at (5,128) size 18x181
       text run at (5,128) width 182 RTL: "Lorem ipsum dolor sit amet, "
     RenderImage {IMG} at (1,103) size 25x25
     RenderText {#text} at (5,-439) size 18x542
       text run at (5,-438) width 542 RTL: " consectetur adipiscing elit. Vivamus vitae eros non libero faucibus sagittis sed ut eros."
-layer at (8,2644) size 27x310 clip at (9,2645) size 25x308 scrollY 435 scrollHeight 743
+layer at (8,2644) size 27x310 clip at (9,2645) size 25x308 scrollY 410 scrollHeight 743
   RenderBlock {DIV} at (0,2635) size 27x311 [border: (1px solid #000000)]
     RenderText {#text} at (5,38) size 18x271
       text run at (5,38) width 272 RTL: "Lorem ipsum dolor sit amet, consectetur ad"

[Fujii Hironori]

Mac port also fails.

https://build.webkit.org/results/Apple-Sequoia-Debug-AppleSilicon-WK2-Tests/308411@main%20(3405)/fast/css/vertical-text-overflow-ellipsis-text-align-center-mixed-diff.txt

--- /Volumes/Data/worker/Apple-Sequoia-Debug-AppleSilicon-WK2-Tests/build/layout-test-results/fast/css/vertical-text-overflow-ellipsis-text-align-center-mixed-expected.txt
+++ /Volumes/Data/worker/Apple-Sequoia-Debug-AppleSilicon-WK2-Tests/build/layout-test-results/fast/css/vertical-text-overflow-ellipsis-text-align-center-mixed-actual.txt
@@ -77,14 +77,14 @@
     RenderText {#text} at (55,-406) size 18x715
       text run at (55,-405) width 715 RTL: "em ipsum dolor sit amet, consectetur adipiscing elit. Vivamus vitae eros non libero faucibus sagittis sed ut eros."
     RenderBR {BR} at (55,-406) size 18x1
-layer at (8,2273) size 27x310 clip at (9,2274) size 25x308 scrollY 459 scrollHeight 767
+layer at (8,2273) size 27x310 clip at (9,2274) size 25x308 scrollY 434 scrollHeight 767
   RenderBlock {DIV} at (0,2265) size 27x311 [border: (1px solid #000000)]
     RenderText {#text} at (5,123) size 18x186
       text run at (5,123) width 186 RTL: "Lorem ipsum dolor sit amet, "
     RenderImage {IMG} at (1,98) size 25x26
     RenderText {#text} at (5,-458) size 18x557
       text run at (5,-457) width 556 RTL: " consectetur adipiscing elit. Vivamus vitae eros non libero faucibus sagittis sed ut eros."
-layer at (8,2644) size 27x310 clip at (9,2645) size 25x308 scrollY 455 scrollHeight 763
+layer at (8,2644) size 27x310 clip at (9,2645) size 25x308 scrollY 430 scrollHeight 763
   RenderBlock {DIV} at (0,2635) size 27x311 [border: (1px solid #000000)]
     RenderText {#text} at (5,31) size 18x278
       text run at (5,31) width 278 RTL: "Lorem ipsum dolor sit amet, consectetur ad"

[Alexey Proskuryakov]

The test doesn't do any scrolling AFAICT, and scrollY is off by 15. I wonder if it's some setting leaking from a preceding test.

[Fujii Hironori]

greenbox.png is 25x25. I think it should wait for the image loaded.

[Alexey Proskuryakov]

Indeed, 25 not 15.

I don't see what in the test could make it not wait though. The results are dumped after everything is loaded, and a forced layout.

[Simon Fraser (smfr)]

For me it passes in Release, fails in Debug.

This is caused by scroll anchoring. I'll disable it for this test.

[Simon Fraser (smfr)]

diff --git a/LayoutTests/fast/css/vertical-text-overflow-ellipsis-text-align-center-mixed.html b/LayoutTests/fast/css/vertical-text-overflow-ellipsis-text-align-center-mixed.html
index 083a89289ba2efe964fb4a7ed732bda7c53da050..7bdf967ca310c3cfbb8fc9de21399dd1cce613c9 100644
--- a/LayoutTests/fast/css/vertical-text-overflow-ellipsis-text-align-center-mixed.html
+++ b/LayoutTests/fast/css/vertical-text-overflow-ellipsis-text-align-center-mixed.html
@@ -1,3 +1,4 @@
+<!-- webkit-test-runner [ CSSScrollAnchoringEnabled=false ] -->
 <META HTTP-EQUIV="CONTENT-TYPE" CONTENT="TEXT/HTML; CHARSET=utf8">
 <head>
 <style>

[Radar WebKit Bug Importer]

<rdar://problem/171826101>

[Simon Fraser (smfr)]

Pull request: https://github.com/WebKit/WebKit/pull/59988

[EWS]

Test gardening commit 308732@main (54f235bdbf71): <https://commits.webkit.org/308732@main>

Reviewed commits have been landed. Closing PR #59988 and removing active labels.

[Alexey Proskuryakov]

Simon, do you consider this to be a permanent resolution, or temporary? Asking because this bug remains open.

[Carlos Alberto Lopez Perez]

BTW,  fast/css/vertical-text-overflow-ellipsis-text-align-center.html (without the -mixed) is also flaky. Does it also need this same fix?

See: https://results.webkit.org/?suite=layout-tests&test=fast%2Fcss%2Fvertical-text-overflow-ellipsis-text-align-center.html

[Simon Fraser (smfr)]

Yes, I will fix that one too.

[Simon Fraser (smfr)]

Pull request: https://github.com/WebKit/WebKit/pull/60101

[EWS]

Committed 308832@main (924852ab6f54): <https://commits.webkit.org/308832@main>

Reviewed commits have been landed. Closing PR #60101 and removing active labels.