Bug 30908 – [GTK] Spell Check Suggestions (Do not work)

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Matthew]

Currently I am using midori-git with webkit 1.1.15.3. I am also compiling the nightly build, r50235, as I am posting this. However, I doubt this build will solve the issue, as the issue has existed for at least a year now.

Currently, misspelled words are underline with a red squiggly line. If you right click on the word a menu shows up with undo, redo, cut, copy paste, select all, spelling + grammar, and input methods. If I highlight/select the word and right click, I get the menu I just described with spelling suggestions at the top. However, any selection I pick will cause the highlighted word to get deleted.

Let me know if you need any additional information and if there is anyway I can help resolve the issue.

Thank you!

[Daniel Michalik]

I confirm this issue. Choosing a suggestion results in the string being removed without the suggestion appearing. I furthermore want to add that I find it very confusing that I have to mark the whole word first. From other browsers, namely the gecko engine, I'm used to just right-clicking a red underlined word to get suggestions immediately. I would prefer this way a lot, right now the spell check suggestions are just not usable at all.

[Christian Dywan]

Created attachment 45232 [details]
Implement 'title' in ContextMenuItemGtk

[WebKit Review Bot]

style-queue ran check-webkit-style on attachment 45232 [details] without any errors.

[Matthew]

I compiled the patch against the nightly 52242 tarball and it works wonderfully! Thank you so much!

[Eric Seidel (no email)]

Looks OK to me.

[Evan Martin]

(In reply to comment #1)
> I confirm this issue. Choosing a suggestion results in the string being removed
> without the suggestion appearing. I furthermore want to add that I find it very
> confusing that I have to mark the whole word first. From other browsers, namely
> the gecko engine, I'm used to just right-clicking a red underlined word to get
> suggestions immediately. I would prefer this way a lot, right now the spell
> check suggestions are just not usable at all.

The right click bug is this one:
https://bugs.webkit.org/show_bug.cgi?id=32770

[Christian Dywan]

2009-12-27  Christian Dywan  <[e-mail]>

        Reviewed by Eric Seidel.

        [GTK] Spell Check Suggestions (Do not work)
        https://bugs.webkit.org/show_bug.cgi?id=30908

        * platform/gtk/ContextMenuItemGtk.cpp:
        (WebCore::ContextMenuItem::ContextMenuItem):
        (WebCore::ContextMenuItem::title):
        (WebCore::ContextMenuItem::setTitle): Implement the 'title' member
        and set the title from the native menu item.