Bug 30890 - Windows build: changes in header files do not always trigger correct rebuild.
Summary: Windows build: changes in header files do not always trigger correct rebuild.
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows Vista
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-10-28 16:58 PDT by Dmitry Titov
Modified: 2010-11-10 04:54 PST (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitry Titov 2009-10-28 16:58:32 PDT
Example: recent change to JavaScriptCore/wtf/MessageQueue.h broke the Windows build because MessageQueue.h is not included anywhere in JavaScriptCore so the project JavaScriptCore was not build. this project has "post-build step" which make copy of header files to the build directory from where the subsequent WebCore build includes JSC headers. As a result, the stale header of MessageQueue.h was used and build broke.

Changing a cpp file from wtf caused recompile of JavaScriptCore and updated the headers.

I'm not sure what the right fix for this is.
Comment 1 Adam Roben (:aroben) 2010-11-10 04:54:10 PST
The right fix is to move all header copying into a Makefile-based project (like JavaScriptCoreGenerated). Makefile-based projects run on every build regardless of whether any .cpp files changed.