WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
NEW
30890
Windows build: changes in header files do not always trigger correct rebuild.
https://bugs.webkit.org/show_bug.cgi?id=30890
Summary
Windows build: changes in header files do not always trigger correct rebuild.
Dmitry Titov
Reported
2009-10-28 16:58:32 PDT
Example: recent change to JavaScriptCore/wtf/MessageQueue.h broke the Windows build because MessageQueue.h is not included anywhere in JavaScriptCore so the project JavaScriptCore was not build. this project has "post-build step" which make copy of header files to the build directory from where the subsequent WebCore build includes JSC headers. As a result, the stale header of MessageQueue.h was used and build broke. Changing a cpp file from wtf caused recompile of JavaScriptCore and updated the headers. I'm not sure what the right fix for this is.
Attachments
Add attachment
proposed patch, testcase, etc.
Adam Roben (:aroben)
Comment 1
2010-11-10 04:54:10 PST
The right fix is to move all header copying into a Makefile-based project (like JavaScriptCoreGenerated). Makefile-based projects run on every build regardless of whether any .cpp files changed.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug