Bug 308856 – [macOS debug] http/tests/websocket/tests/hybi/handshake-ok-with-legacy-websocket-response-headers.html is a flaky text failure.

• Status: NEW
• Component: New Bugs

[Diego De La Toba]

http/tests/websocket/tests/hybi/handshake-ok-with-legacy-websocket-response-headers.html is a flaky text failure on macOS debug.


HISTORY:
https://results.webkit.org/?suite=layout-tests&test=http%2Ftests%2Fwebsocket%2Ftests%2Fhybi%2Fhandshake-ok-with-legacy-websocket-response-headers.html


TEXT DIFF:
--- /Volumes/Data/worker/Apple-Tahoe-Debug-AppleSilicon-WK2-Tests/build/layout-test-results/http/tests/websocket/tests/hybi/handshake-ok-with-legacy-websocket-response-headers-expected.txt
+++ /Volumes/Data/worker/Apple-Tahoe-Debug-AppleSilicon-WK2-Tests/build/layout-test-results/http/tests/websocket/tests/hybi/handshake-ok-with-legacy-websocket-response-headers-actual.txt
@@ -1,3 +1,4 @@
+CONSOLE MESSAGE: WebSocket connection to 'ws://localhost:8880/websocket/tests/hybi/handshake-ok-with-legacy-websocket-response-headers' failed: The operation couldn’t be completed. Socket is not connected
 Test whether WebSocket handshake is OK with legacy response headers 'WebSocket-Location' and 'WebSocket-Origin'.
 
 On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".


DIFF URL:
https://build.webkit.org/results/Apple-Tahoe-Debug-AppleSilicon-WK2-Tests/308364%40main%20(1062)/http/tests/websocket/tests/hybi/handshake-ok-with-legacy-websocket-response-headers-pretty-diff.html


REPRODUCTION:
Reproduced on macOS 26.2 arm64 debug with the following:

run-webkit-tests --no-build --no-retry --no-show-results --exit-after-n-failures=1 --expect-pass --iterations=1000 --force -f --debug http/tests/websocket/tests/hybi/handshake-ok-with-legacy-websocket-response-headers.html

I am going to mark expectations as pass fail while this pends investigation.

[Radar WebKit Bug Importer]

<rdar://problem/171394530>

[Diego De La Toba]

Pull request: https://github.com/WebKit/WebKit/pull/59619

[EWS]

Test gardening commit 308373@main (b3c6044a99a7): <https://commits.webkit.org/308373@main>

Reviewed commits have been landed. Closing PR #59619 and removing active labels.

[Diego De La Toba]

This test is flaky due to the websocket handler abruptly closing the connection after sending a handshake response which sends out a connection lost error. What appears to be happening is the test harness is sometimes receiving this error message and logging it as an error when the test did pass. Adjusting the actual WebSocket to close the connection more gracefully seems like a more robust solution and does resolve all flakes when testing locally. However, also adjusting the actual test to account for this could be another solution.

[Diego De La Toba]

Pull request: https://github.com/WebKit/WebKit/pull/59632