Bug 30875 – Web Inspector: Pull items collections from resources panel and timeline panel into AbstractTimelinePanel.

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Pavel Feldman]

The idea is to implement Timeline panel as two AbstractTimelinePanels: top and bottom. Hence I'd like reuse more code in AbstractTimelinePanel. It is now capable of rendering tree to the left and grid to the right provided constructors for tree elements and bars. All the refresh, reset, add, remove code is unified.

[Pavel Feldman]

Created attachment 42049 [details]
[PATCH] Pulls collections + does some more unification.

[Timothy Hatcher]

Comment on attachment 42049 [details]
[PATCH] Pulls collections + does some more unification.


> +                // Create the resource tree element and graph.

Mentions resources.


> +            this._recordStyles[recordTypes.XHRReadyStateChange] = { title: WebInspector.UIString("XHR Ready State Change"), category: this.categories.loading };
> +            this._recordStyles[recordTypes.XHRLoad] = { title: WebInspector.UIString("XHR Load"), category: this.categories.loading };

I think these should be under scripting not loading, sicne they only wrap the DOM event call into javascript, not the load.

Once we show resources you will see the XHR resource too as a load bar.

[Pavel Feldman]

Landed with comments addressed...

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/inspector/front-end/AbstractTimelinePanel.js
	M	WebCore/inspector/front-end/ResourceCategory.js
	M	WebCore/inspector/front-end/ResourcesPanel.js
	M	WebCore/inspector/front-end/TimelinePanel.js
	M	WebCore/inspector/front-end/inspector.css
	M	WebCore/inspector/front-end/inspector.html
Committed r50236