Bug 30875 - Web Inspector: Pull items collections from resources panel and timeline panel into AbstractTimelinePanel.
Summary: Web Inspector: Pull items collections from resources panel and timeline panel...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-10-28 12:28 PDT by Pavel Feldman
Modified: 2009-10-28 14:17 PDT (History)
1 user (show)

See Also:


Attachments
[PATCH] Pulls collections + does some more unification. (41.67 KB, patch)
2009-10-28 12:30 PDT, Pavel Feldman
timothy: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2009-10-28 12:28:34 PDT
The idea is to implement Timeline panel as two AbstractTimelinePanels: top and bottom. Hence I'd like reuse more code in AbstractTimelinePanel. It is now capable of rendering tree to the left and grid to the right provided constructors for tree elements and bars. All the refresh, reset, add, remove code is unified.
Comment 1 Pavel Feldman 2009-10-28 12:30:37 PDT
Created attachment 42049 [details]
[PATCH] Pulls collections + does some more unification.
Comment 2 Timothy Hatcher 2009-10-28 13:38:14 PDT
Comment on attachment 42049 [details]
[PATCH] Pulls collections + does some more unification.


> +                // Create the resource tree element and graph.

Mentions resources.


> +            this._recordStyles[recordTypes.XHRReadyStateChange] = { title: WebInspector.UIString("XHR Ready State Change"), category: this.categories.loading };
> +            this._recordStyles[recordTypes.XHRLoad] = { title: WebInspector.UIString("XHR Load"), category: this.categories.loading };

I think these should be under scripting not loading, sicne they only wrap the DOM event call into javascript, not the load.

Once we show resources you will see the XHR resource too as a load bar.
Comment 3 Pavel Feldman 2009-10-28 14:17:58 PDT
Landed with comments addressed...

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/inspector/front-end/AbstractTimelinePanel.js
	M	WebCore/inspector/front-end/ResourceCategory.js
	M	WebCore/inspector/front-end/ResourcesPanel.js
	M	WebCore/inspector/front-end/TimelinePanel.js
	M	WebCore/inspector/front-end/inspector.css
	M	WebCore/inspector/front-end/inspector.html
Committed r50236