Bug 30866 - Web Inspector: Add InspectorController stub in order to support opening in standalone mode.
Summary: Web Inspector: Add InspectorController stub in order to support opening in st...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-10-28 09:17 PDT by Pavel Feldman
Modified: 2009-10-28 10:03 PDT (History)
1 user (show)

See Also:

Attachments
[PATCH] stub (12.36 KB, patch)
2009-10-28 09:23 PDT, Pavel Feldman 		timothy: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2009-10-28 09:17:13 PDT 
I want to be able to open inspector.html as a regular Web App.
Comment 1 Pavel Feldman 2009-10-28 09:23:31 PDT 
Created attachment 42035 [details]
[PATCH] stub
Comment 2 Timothy Hatcher 2009-10-28 09:35:37 PDT 
Comment on attachment 42035 [details]
[PATCH] stub

> +    <script type="text/javascript" src="InspectorControllerStub.js"></script>

This should probably be added first.

> +       this._windowVisible = false;
> +       this._searchingForNode = !this._searchingForNode;

Bad indents here.

> +     wrapCallback: function f(func)

Why name this function "f"?
Comment 3 Pavel Feldman 2009-10-28 10:03:33 PDT 
Landed with comments addressed.

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/WebCore.gypi
	M	WebCore/WebCore.vcproj/WebCore.vcproj
	A	WebCore/inspector/front-end/InspectorControllerStub.js
	M	WebCore/inspector/front-end/inspector.html
	M	WebCore/inspector/front-end/inspector.js
Committed r50221