WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
30866
Web Inspector: Add InspectorController stub in order to support opening in standalone mode.
https://bugs.webkit.org/show_bug.cgi?id=30866
Summary
Web Inspector: Add InspectorController stub in order to support opening in st...
Pavel Feldman
Reported
2009-10-28 09:17:13 PDT
I want to be able to open inspector.html as a regular Web App.
Attachments
[PATCH] stub
(12.36 KB, patch)
2009-10-28 09:23 PDT
,
Pavel Feldman
timothy
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Pavel Feldman
Comment 1
2009-10-28 09:23:31 PDT
Created
attachment 42035
[details]
[PATCH] stub
Timothy Hatcher
Comment 2
2009-10-28 09:35:37 PDT
Comment on
attachment 42035
[details]
[PATCH] stub
> + <script type="text/javascript" src="InspectorControllerStub.js"></script>
This should probably be added first.
> + this._windowVisible = false; > + this._searchingForNode = !this._searchingForNode;
Bad indents here.
> + wrapCallback: function f(func)
Why name this function "f"?
Pavel Feldman
Comment 3
2009-10-28 10:03:33 PDT
Landed with comments addressed. Committing to
http://svn.webkit.org/repository/webkit/trunk
... M WebCore/ChangeLog M WebCore/WebCore.gypi M WebCore/WebCore.vcproj/WebCore.vcproj A WebCore/inspector/front-end/InspectorControllerStub.js M WebCore/inspector/front-end/inspector.html M WebCore/inspector/front-end/inspector.js Committed
r50221
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug