RESOLVED FIXED 30864
[Qt] Implement symbol hiding for JSC's JIT functions. 
https://bugs.webkit.org/show_bug.cgi?id=30864
Summary [Qt] Implement symbol hiding for JSC's JIT functions.
Jocelyn Turcotte
Reported 2009-10-28 09:12:17 PDT
These functions are implemented directly in assembly, so they need the proper directives to enable/disable visibility. On ELF systems, it's .hidden, whereas on Mach-O systems (Mac) it's .private_extern. On Windows, it's not necessary since you have to explicitly export. I also implemented the AIX idiom, though it's unlikely anyone will implement AIX/POWER JIT.
Attachments
Patch (7.87 KB, patch)
2009-10-28 09:12 PDT, Jocelyn Turcotte 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jocelyn Turcotte
Comment 1 2009-10-28 09:12:56 PDT
Created attachment 42033 [details] Patch
Eric Seidel (no email)
Comment 2 2009-10-29 11:43:45 PDT
FYI, svn-apply (and thus the commit-queue) will fail to handle this patch until bug 30683 is landed (which will hopefully be soon).
Eric Seidel (no email)
Comment 3 2009-11-11 10:23:54 PST
This looks sane to me, but Gavin or Oliver are really your best people to review this.
Eric Seidel (no email)
Comment 4 2009-11-13 13:31:38 PST
I'm confused that the ChangeLog says Thiago Macieira, and yet Jocelyn Turcotte attached the patch. Neither of you have committer powers AFAIK, so I would add this to the commit-queue, except that I fear the ChangeLog may list the wrong person?
Kenneth Rohde Christiansen
Comment 5 2009-11-13 13:45:22 PST
(In reply to comment #4) > I'm confused that the ChangeLog says Thiago Macieira, and yet Jocelyn Turcotte > attached the patch. Neither of you have committer powers AFAIK, so I would add > this to the commit-queue, except that I fear the ChangeLog may list the wrong > person? Thiago is a Qt product manager and developer. He has a lot of experience of making Qt compile on all of our supported platforms. As Qt distributes WebKit as part of it's source code, Thiago probably did the patch for Qt and not trunk WebKit. As many of the Qt developers is not working directly on WebKit, but still make fixes as part of Qt (think documentation as well), Jocelyn is trying to upstream those patches and has thus rebased them to trunk WebKit and added them to Bugzilla. I think this explains the situation.
WebKit Commit Bot
Comment 6 2009-11-18 15:02:37 PST
Comment on attachment 42033 [details] Patch Clearing flags on attachment: 42033 Committed r51141: <http://trac.webkit.org/changeset/51141>
WebKit Commit Bot
Comment 7 2009-11-18 15:02:59 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.