RESOLVED FIXED 30861
WebInspector: Adds InspectorTimelineAgent instrumentation for <script> tag processing 
https://bugs.webkit.org/show_bug.cgi?id=30861
Summary WebInspector: Adds InspectorTimelineAgent instrumentation for <script> tag pr...
Eric Ayers
Reported 2009-10-28 08:30:17 PDT
This change adds another instrumentation point for the InspectorTimelineAgent - reporting the time spent processing a script tag. In order to report the URL and line number for the tag, I updated SourceSourceCode to provide accessors for these values. I could have de-referenced the JSC object, but that would cause a fork with Chrome.
Attachments
WebInspector: Adds instrumentation of the script tag, and getters to ScriptSourceCode (8.44 KB, patch)
2009-10-28 08:40 PDT, Eric Ayers 		timothy: review-
DetailsFormatted DiffDiff
WebInspector: Renames ScriptTagTimelineRecord to EvaluateScriptTagTimelineRecord (8.53 KB, patch)
2009-10-28 10:44 PDT, Eric Ayers 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eric Ayers
Comment 1 2009-10-28 08:40:35 PDT
Created attachment 42031 [details] WebInspector: Adds instrumentation of the script tag, and getters to ScriptSourceCode
Timothy Hatcher
Comment 2 2009-10-28 09:28:11 PDT
Comment on attachment 42031 [details] WebInspector: Adds instrumentation of the script tag, and getters to ScriptSourceCode > + timelineAgent->willScriptTag(sourceCode.url().isNull() ? String() : sourceCode.url().string(), sourceCode.startLine()); > + timelineAgent->didScriptTag(); > + ScriptTagTimelineRecordType = 10, The wording is weird here. Would be better as willEvaluateScriptTag/didEvaluateScriptTag/EvaluateScriptTagTimelineRecordType. Otherwise r+.
Eric Ayers
Comment 3 2009-10-28 10:44:07 PDT
Created attachment 42042 [details] WebInspector: Renames ScriptTagTimelineRecord to EvaluateScriptTagTimelineRecord
WebKit Commit Bot
Comment 4 2009-10-28 12:52:49 PDT
Comment on attachment 42042 [details] WebInspector: Renames ScriptTagTimelineRecord to EvaluateScriptTagTimelineRecord Clearing flags on attachment: 42042 Committed r50230: <http://trac.webkit.org/changeset/50230>
WebKit Commit Bot
Comment 5 2009-10-28 12:52:53 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.