Bug 30861 - WebInspector: Adds InspectorTimelineAgent instrumentation for <script> tag processing
Summary: WebInspector: Adds InspectorTimelineAgent instrumentation for <script> tag pr...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-10-28 08:30 PDT by Eric Ayers
Modified: 2009-10-28 12:52 PDT (History)
4 users (show)

See Also:


Attachments
WebInspector: Adds instrumentation of the script tag, and getters to ScriptSourceCode (8.44 KB, patch)
2009-10-28 08:40 PDT, Eric Ayers
timothy: review-
Details | Formatted Diff | Diff
WebInspector: Renames ScriptTagTimelineRecord to EvaluateScriptTagTimelineRecord (8.53 KB, patch)
2009-10-28 10:44 PDT, Eric Ayers
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Ayers 2009-10-28 08:30:17 PDT
This change adds another instrumentation point for the InspectorTimelineAgent - reporting the time spent processing a script tag.

In order to report the URL and line number for the tag, I updated SourceSourceCode to provide accessors for these values.  I could have de-referenced the JSC object, but that would cause a fork with Chrome.
Comment 1 Eric Ayers 2009-10-28 08:40:35 PDT
Created attachment 42031 [details]
WebInspector: Adds instrumentation of the script tag, and getters to ScriptSourceCode
Comment 2 Timothy Hatcher 2009-10-28 09:28:11 PDT
Comment on attachment 42031 [details]
WebInspector: Adds instrumentation of the script tag, and getters to ScriptSourceCode


> +        timelineAgent->willScriptTag(sourceCode.url().isNull() ? String() : sourceCode.url().string(), sourceCode.startLine());
> +        timelineAgent->didScriptTag();
> +        ScriptTagTimelineRecordType = 10,

The wording is weird here. Would be better as willEvaluateScriptTag/didEvaluateScriptTag/EvaluateScriptTagTimelineRecordType.

Otherwise r+.
Comment 3 Eric Ayers 2009-10-28 10:44:07 PDT
Created attachment 42042 [details]
WebInspector: Renames ScriptTagTimelineRecord to EvaluateScriptTagTimelineRecord
Comment 4 WebKit Commit Bot 2009-10-28 12:52:49 PDT
Comment on attachment 42042 [details]
WebInspector: Renames ScriptTagTimelineRecord to EvaluateScriptTagTimelineRecord

Clearing flags on attachment: 42042

Committed r50230: <http://trac.webkit.org/changeset/50230>
Comment 5 WebKit Commit Bot 2009-10-28 12:52:53 PDT
All reviewed patches have been landed.  Closing bug.