Bug 308592 – [EWS] build-product-archive is not running after rebuilding for retries on builder queue

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Ryan Haddad]

Looking at https://ews-build.webkit.org/#/builders/168/builds/12834 as an example:

1. We compile webkit with the PR in https://ews-build.webkit.org/#/builders/168/builds/12834#bb-step-15
2. We run the built-product-archive step in https://ews-build.webkit.org/#/builders/168/builds/12834#bb-step-18 to create release.zip
3. We upload that file to S3 in https://ews-build.webkit.org/#/builders/168/builds/12834#bb-step-20
4. We compile webkit without the change in https://ews-build.webkit.org/#/builders/168/builds/12834#bb-step-24
5. We don't re-run built-product-archive before uploading release.zip in https://ews-build.webkit.org/#/builders/168/builds/12834#bb-step-28

This suggests that we're uploading the archive built against the PR twice, which means our "without change" test runs are invalid. 

https://ews-build.webkit.org/#/builders/169/builds/11048 is an example of failures introduced by the PR being flagged as pre-existing since they also failed in the `run-layout-tests-without-change` step.

[Radar WebKit Bug Importer]

<rdar://problem/171120066>

[Radar WebKit Bug Importer]

<rdar://problem/171120090>

[Ryan Haddad]

Pull request: https://github.com/WebKit/WebKit/pull/59426

[EWS]

Committed 308211@main (5718d09a26c2): <https://commits.webkit.org/308211@main>

Reviewed commits have been landed. Closing PR #59426 and removing active labels.