Bug 30858 - Allow custom memory allocation control for WebCore's RareData
Summary: Allow custom memory allocation control for WebCore's RareData
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-10-28 05:55 PDT by Zoltan Horvath
Modified: 2009-10-29 08:46 PDT (History)
0 users

See Also:

Attachments
proposed patch (1.12 KB, patch)
2009-10-28 05:56 PDT, Zoltan Horvath 		darin: review+
Details | Formatted Diff | Diff
updated to Noncopyable (1.14 KB, patch)
2009-10-29 03:16 PDT, Zoltan Horvath 		darin: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zoltan Horvath 2009-10-28 05:55:11 PDT 
Inherits RareData struct from FastAllocBase because it has been instantiated by 'new' in WebCore/css/CSSSelector.h:259.
Comment 1 Zoltan Horvath 2009-10-28 05:56:34 PDT 
Created attachment 42023 [details]
proposed patch
Comment 2 Darin Adler 2009-10-28 07:47:02 PDT 
Comment on attachment 42023 [details]
proposed patch

For any of these there is no need to be copyable, it may be more appropriate to inherit from Noncopyable than from FastAllocBase. This is one of those examples.
Comment 3 Zoltan Horvath 2009-10-29 03:16:24 PDT 
Created attachment 42086 [details]
updated to Noncopyable
Comment 4 Zoltan Horvath 2009-10-29 08:46:33 PDT 
Landed in 50274.
https://trac.webkit.org/changeset/50274