RESOLVED FIXED 30843
WAI-ARIA: add support for 'option' role 
https://bugs.webkit.org/show_bug.cgi?id=30843
Summary WAI-ARIA: add support for 'option' role
chris fleizach
Reported 2009-10-27 20:48:59 PDT
WAI-ARIA: add support for 'option' role * NOTES http://www.w3.org/TR/wai-aria/#option Equivalent semantics to HTML option
Attachments
patch (6.20 KB, patch)
2009-10-27 23:23 PDT, chris fleizach 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
chris fleizach
Comment 1 2009-10-27 23:23:59 PDT
Created attachment 42002 [details] patch
Darin Adler
Comment 2 2009-10-27 23:45:21 PDT
Comment on attachment 42002 [details] patch Does the test case test the "canHaveChildren = false" aspect of this patch? By the way, for an override like AccessibilityListBoxOption’s canHaveChildren, which always returns a constant, I suggest private visibility rather than public. Anyone who has an AccessibilityListOption* already won't want to call the function, so it can be private. And anyone who has a pointer to the base class will still be able to call the function and get the override version. r=me
chris fleizach
Comment 3 2009-10-28 19:24:06 PDT
i will modify the test to also test the canHaveChildren feature
chris fleizach
Comment 4 2009-10-28 19:49:28 PDT
http://trac.webkit.org/changeset/50256
Eric Seidel (no email)
Comment 5 2009-10-29 13:39:02 PDT
Looks like this was landed. Closing.
Note You need to log in before you can comment on or make changes to this bug.