Bug 30842 - Support ARIA "tab" roles
: Support ARIA "tab" roles
Status: RESOLVED FIXED
: WebKit
Accessibility
: 528+ (Nightly build)
: PC Mac OS X 10.5
: P2 Normal
Assigned To:
:
:
:
:
  Show dependency treegraph
 
Reported: 2009-10-27 20:07 PST by
Modified: 2009-11-02 08:58 PST (History)


Attachments
patch (40.25 KB, patch)
2009-11-01 22:06 PST, chris fleizach
bdakin: review+
Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2009-10-27 20:07:47 PST
tab, tabpanel and tablist
------- Comment #1 From 2009-10-28 23:48:41 PST -------
tab needs to support AXValue (whether its selected... which can be either if an item in its associated tab panel has focus, or it has aria-selected)

a tab can also be selected if KB focus is in one of its aria-controls elements

tablist needs to support AXValue = selected tab, AXContents (children that are not tabs) and AXTabs (children that are tabs)

tabpanel needs to be an AXGroup with a subrole, like the other aria landmarks

make sure this works
http://codetalks.org/source/widgets/tabpanel/tabpanel1.html
------- Comment #2 From 2009-11-01 22:06:50 PST -------
Created an attachment (id=42300) [details]
patch

Beth, I've made these tab roles like we talked about
tab = AXRadioButton
tablist = AXTabGroup
tabpanel = AXGroup:AXTabPanel

I also mirrored the other Mac accessibility things relating to tabs, and tried to follow ARIA spec.

I re-organized some code so that it would be easy to get all Elements from a specific attribute. 

As a note, when i ran update-webkit-strings, it removed two accessibility strings. i guess those are no longer used...
------- Comment #3 From 2009-11-01 22:07:32 PST -------
Beth, can you review this one. One of the ARIA things we talked about
------- Comment #4 From 2009-11-01 22:33:47 PST -------
(From update of attachment 42300 [details])
Nice! r=me
------- Comment #5 From 2009-11-02 08:58:19 PST -------
http://trac.webkit.org/changeset/50409